Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 9706052: [uber page] Fix row delete buttons on all lists in options. (Closed)

Created:
8 years, 9 months ago by Dan Beam
Modified:
8 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[uber page] Fix row delete buttons on all lists in options. TBR=estade BUG=None? TEST=Delete buttons in lists actually do something. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126861

Patch Set 1 #

Patch Set 2 : removing overlay-related stuff #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options2/deletable_item_list.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9706052/4001
8 years, 9 months ago (2012-03-15 07:25:30 UTC) #1
commit-bot: I haz the power
Change committed as 126861
8 years, 9 months ago (2012-03-15 07:34:18 UTC) #2
Evan Stade
8 years, 9 months ago (2012-03-15 21:30:35 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698