Ash: Extend tabs to top of window for maximized windows

chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h"
 
 #include "ash/wm/frame_painter.h"
 #include "ash/wm/workspace/frame_maximize_button.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/views/frame/browser_frame.h"
@@ skipping 14 matching lines @@
 
 namespace {
 
 // Space between left edge of window and tabstrip.
 const int kTabstripLeftSpacing = 4;
 // Space between right edge of tabstrip and maximize button.
 const int kTabstripRightSpacing = 10;
 // Space between top of window and top of tabstrip for restored windows.
 const int kTabstripTopSpacingRestored = 10;
 // Space between top of window and top of tabstrip for maximized windows.
-const int kTabstripTopSpacingMaximized = 1;
+// Place them flush to the top to make them clickable when the cursor is at
+// the screen edge.
+const int kTabstripTopSpacingMaximized = 0;
 
 }  // namespace
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserNonClientFrameViewAura, public:
 
 BrowserNonClientFrameViewAura::BrowserNonClientFrameViewAura(
     BrowserFrame* frame, BrowserView* browser_view)
     : BrowserNonClientFrameView(frame, browser_view),
       maximize_button_(NULL),
@@ skipping 28 matching lines @@
   frame_painter_->Init(frame(), window_icon_, maximize_button_, close_button_);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserNonClientFrameView overrides:
 
 gfx::Rect BrowserNonClientFrameViewAura::GetBoundsForTabStrip(
     views::View* tabstrip) const {
   if (!tabstrip)
     return gfx::Rect();
-  bool restored = !frame()->IsMaximized();
   return gfx::Rect(kTabstripLeftSpacing,
-                   GetHorizontalTabStripVerticalOffset(restored),
+                   GetHorizontalTabStripVerticalOffset(false),

[James Cook, 2012/03/15 17:31:12]

This function doesn't take the *current* restored state, it takes a
*force_restored* option that overrides the current state.  I fixed the parameter
name in an earlier CL, this is just cleanup.

                    std::max(0, maximize_button_->x() - kTabstripRightSpacing),
                    tabstrip->GetPreferredSize().height());
 }
 
 int BrowserNonClientFrameViewAura::GetHorizontalTabStripVerticalOffset(
     bool force_restored) const {
   return NonClientTopBorderHeight(force_restored);
 }
 
 void BrowserNonClientFrameViewAura::UpdateThrobber(bool running) {
@@ skipping 248 matching lines @@
 }
 
 SkBitmap* BrowserNonClientFrameViewAura::GetCustomBitmap(
     int bitmap_id,
     int fallback_bitmap_id) const {
   ui::ThemeProvider* tp = GetThemeProvider();
   if (tp->HasCustomImage(bitmap_id))
     return tp->GetBitmapNamed(bitmap_id);
   return tp->GetBitmapNamed(fallback_bitmap_id);
 }