Issue 9706036: settings - share inline list button style between different list types

Issue 9706036: settings - share inline list button style between different list types (Closed)

Created:
8 years, 9 months ago by Evan Stade

Modified:
8 years, 9 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

settings - share inline list button style between different list types BUG=117643, 117638 (#2) TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126807

Patch Set 1 #

Total comments: 5

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -133 lines)			Patch
A +	chrome/browser/resources/options2/autofill_edit_overlay.css	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/options2/autofill_options.css	View	3 chunks	+5 lines, -8 lines	2 comments	Download
M	chrome/browser/resources/options2/autofill_options_list.js	View	1 chunk	+2 lines, -3 lines	0 comments	Download
D	chrome/browser/resources/options2/autofill_overlay.css	View	1 chunk	+0 lines, -101 lines	0 comments	Download
M	chrome/browser/resources/options2/options.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options2/options_page.css	View	1 chunk	+15 lines, -0 lines	3 comments	Download
M	chrome/browser/resources/options2/password_manager_list.css	View	1 chunk	+3 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/options2/password_manager_list.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options2/search_engine_manager.css	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/options2/search_engine_manager_engine_list.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

lgtm w/nits http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/options2/autofill_options.css File chrome/browser/resources/options2/autofill_options.css (right): http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/options2/autofill_options.css#newcode4 chrome/browser/resources/options2/autofill_options.css:4: nit: why so spatious? http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/options2/options_page.css File chrome/browser/resources/options2/options_page.css ...

8 years, 9 months ago (2012-03-15 00:05:27 UTC) #2

Evan Stade

http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/options2/autofill_options.css File chrome/browser/resources/options2/autofill_options.css (right): http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/options2/autofill_options.css#newcode4 chrome/browser/resources/options2/autofill_options.css:4: On 2012/03/15 00:05:27, Dan Beam wrote: > nit: why ...

8 years, 9 months ago (2012-03-15 00:53:23 UTC) #3

Dan Beam

http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/options2/options_page.css File chrome/browser/resources/options2/options_page.css (right): http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/options2/options_page.css#newcode384 chrome/browser/resources/options2/options_page.css:384: border-radius: 2px; On 2012/03/15 00:53:23, Evan Stade wrote: > ...

8 years, 9 months ago (2012-03-15 03:44:05 UTC) #4

Dan Beam

8 years, 9 months ago (2012-03-15 03:44:22 UTC) #5

On 2012/03/15 03:44:05, Dan Beam wrote:
>
http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/option...
> File chrome/browser/resources/options2/options_page.css (right):
> 
>
http://codereview.chromium.org/9706036/diff/1/chrome/browser/resources/option...
> chrome/browser/resources/options2/options_page.css:384: border-radius: 2px;
> On 2012/03/15 00:53:23, Evan Stade wrote:
> > On 2012/03/15 00:05:27, Dan Beam wrote:
> > > nit: alpha
> > 
> > damn, vim sort is wrong
> 
> export LC_ALL=C will fix, or :XX,XX!LC_ALL=C sort

alternate hack, sort -V

Expand Messages | Collapse Messages