Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 9706029: Roll gyp deps r1242->r1246 (Closed)

Created:
8 years, 9 months ago by scottmg
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Roll gyp deps r1242->r1246 r1243 [windows ninja] Starting with additional includes, defines, and some basic cflags and ldflags r1244 Fix CharacterSet map for VS 2010 r1245 mac make: Don't put host shared libraries into the product directory r1246 Unbreak gyptest-toolsets.py on linux R=thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
8 years, 9 months ago (2012-03-14 19:06:09 UTC) #1
(unused - use chromium)
lgtm On Wed, Mar 14, 2012 at 12:06 PM, <scottmg@chromium.org> wrote: > Reviewers: thakis, > ...
8 years, 9 months ago (2012-03-14 19:09:30 UTC) #2
Nico
(why top-post the revisions though?)
8 years, 9 months ago (2012-03-14 19:10:08 UTC) #3
scottmg
On Wed, Mar 14, 2012 at 12:10 PM, <thakis@chromium.org> wrote: > (why top-post the revisions ...
8 years, 9 months ago (2012-03-14 19:33:37 UTC) #4
(unused - use chromium)
> Copy-paste from http://code.google.com/p/gyp/source/list. Do you have a > quicker way to generate? Ooh, smart! ...
8 years, 9 months ago (2012-03-14 19:38:56 UTC) #5
(unused - use chromium)
On Wed, Mar 14, 2012 at 12:38 PM, Nico Weber <thakis@google.com> wrote: >> Copy-paste from ...
8 years, 9 months ago (2012-03-14 19:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/9706029/1
8 years, 9 months ago (2012-03-14 19:43:37 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 22:10:26 UTC) #8
Change committed as 126757

Powered by Google App Engine
This is Rietveld 408576698