Build Android's MessagePumpForUI by upstreaming SystemMessageHandler

Build Android's MessagePumpForUI by upstreaming SystemMessageHandler

BUG=
TEST=The "DumpRenderTree" target on the FYI bot should link.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126769

[Peter Beverloo, 2012-03-14 16:53:44]

+bulach for Java code
+mark for base/
+yfriedman for general sanity

This fixes the last linking error for DumpRenderTree.

[Mark Mentovai, 2012-03-14 16:58:43]

LGTM

[bulach, 2012-03-14 17:03:07]

lgtm

just one nit below:

https://chromiumcodereview.appspot.com/9706022/diff/1/base/message_pump_andro...
File base/message_pump_android.cc (right):

https://chromiumcodereview.appspot.com/9706022/diff/1/base/message_pump_andro...
base/message_pump_android.cc:19: const char kClassPathName[] =
"org/chromium/base/SystemMessageHandler";
no longer used? could remove downstream too..

[Yaron, 2012-03-14 17:06:33]

lgtm

https://chromiumcodereview.appspot.com/9706022/diff/1/base/android/java/org/c...
File base/android/java/org/chromium/base/SystemMessageHandler.java (right):

https://chromiumcodereview.appspot.com/9706022/diff/1/base/android/java/org/c...
base/android/java/org/chromium/base/SystemMessageHandler.java:1: // Copyright
(c) 2012 The Chromium Authors. All rights reserved.
sidebar: it would be really great if we could get Rietveld to default to 100
chars for *.java files.

[John Grabowski, 2012-03-14 18:06:10]

LGTM

https://chromiumcodereview.appspot.com/9706022/diff/1/base/base.gyp
File base/base.gyp (right):

https://chromiumcodereview.appspot.com/9706022/diff/1/base/base.gyp#newcode126
base/base.gyp:126: 'android/java/org/chromium/base/SystemMessageHandler.java',
consider a gyp regexp for these files.  E.g. '<!(echo android/..../*.java)'
I think the syntax needs a tweak to be a list instead of single string but
something like that should work.

[Peter Beverloo, 2012-03-14 19:49:40]

Thanks, guys!  I've rebaselined the patch and will put it on the CQ.

https://chromiumcodereview.appspot.com/9706022/diff/1/base/base.gyp
File base/base.gyp (right):

https://chromiumcodereview.appspot.com/9706022/diff/1/base/base.gyp#newcode126
base/base.gyp:126: 'android/java/org/chromium/base/SystemMessageHandler.java',
On 2012/03/14 18:06:10, John Grabowski wrote:
> consider a gyp regexp for these files.  E.g. '<!(echo android/..../*.java)'
> I think the syntax needs a tweak to be a list instead of single string but
> something like that should work.
> 

This requires quite some changes in the binding generator, see b/6167736.

https://chromiumcodereview.appspot.com/9706022/diff/1/base/message_pump_andro...
File base/message_pump_android.cc (right):

https://chromiumcodereview.appspot.com/9706022/diff/1/base/message_pump_andro...
base/message_pump_android.cc:19: const char kClassPathName[] =
"org/chromium/base/SystemMessageHandler";
On 2012/03/14 17:03:07, bulach wrote:
> no longer used? could remove downstream too..

Done.

[commit-bot: I haz the power, 2012-03-14 19:50:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/9706022/8

[commit-bot: I haz the power, 2012-03-14 22:17:03]

Change committed as 126769