Remove Ordinals Setters and Getters from ExtensionService

chrome/browser/extensions/extension_sorting.h

Index: chrome/browser/extensions/extension_sorting.h
diff --git a/chrome/browser/extensions/extension_sorting.h b/chrome/browser/extensions/extension_sorting.h
index 3542d51d2777a4c7d1d19d06679325426cfd843a..5519ed852b23ac874f6c0de7b0a924c6e9141f82 100644
--- a/chrome/browser/extensions/extension_sorting.h
+++ b/chrome/browser/extensions/extension_sorting.h
@@ -14,6 +14,7 @@
 #include "chrome/common/string_ordinal.h"
 
 class ExtensionScopedPrefs;
+class ExtensionService;
 
 class ExtensionSorting {
  public:
@@ -21,6 +22,9 @@ class ExtensionSorting {
                             PrefService* pref_service);
   ~ExtensionSorting();
 
+  // Set up the ExtensionService to inform of changes that require syncing.
+  void SetExtensionService(ExtensionService* extension_service);
+
   // Properly initialize ExtensionSorting internal values that require
   // |extension_ids|.
   void Initialize(const ExtensionPrefs::ExtensionIdSet& extension_ids);
@@ -135,6 +139,7 @@ class ExtensionSorting {
 
   ExtensionScopedPrefs* extension_scoped_prefs_;  // Weak, owns this instance.
   PrefService* pref_service_;  // Weak.
+  ExtensionService* extension_service_;  // Weak.

[Aaron Boodman, 2012/03/14 18:54:28]

Instead of having a direct dependency on ExtensionService, consider making it a
dependency on ExtensionServiceInterface. This might allow you to move the unit
tests of ExtensionSorting out into their own file, which would be nice since
extension_service_unittest is so large.

[csharp, 2012/03/15 17:21:19]

Ok, I've changed the dependency. I looked at the tests related to the ordinals
that are in extension_service_unittest and they are testing ExtensionService
functionality, so I don't think they should be moved.

 
   // A map of all the StringOrdinal page ordinals mapping to the collections of
   // app launch ordinals that exist on that page. This is used for mapping