Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 9706016: third_party/protobuf: update to upstream r412. (Closed)

Created:
8 years, 9 months ago by Philippe
Modified:
8 years, 9 months ago
Reviewers:
agl, pliard
CC:
chromium-reviews
Visibility:
Public.

Description

third_party/protobuf: update to upstream r412. 1) Got an upstream diff 411:412 from svn 2) Applied 3) Modified protobuf.gyp to make it platform independent thanks to the new guards added in atomicops_internals_x86_gcc.cc and atomicops_internals_x86_msvc.cc. Note that the previous change adding atomicops added a significant complexity to protobuf.gyp to handle platform-specific source files. Because it was using target_arch only, it did not even work properly. Indeed protobuf_lite needs to deal with the host architecture when it is built to be used by protoc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -32 lines) Patch
M third_party/protobuf/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/protobuf.gyp View 2 chunks +7 lines, -30 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/atomicops_internals_x86_gcc.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/atomicops_internals_x86_msvc.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Philippe
8 years, 9 months ago (2012-03-15 08:48:39 UTC) #1
agl
LGTM. n.b. you codereview tools seem to be out of date as the email contained ...
8 years, 9 months ago (2012-03-15 14:12:03 UTC) #2
pliard
Thanks for the review and letting me know about my depot tools! On Thu, Mar ...
8 years, 9 months ago (2012-03-15 14:15:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/9706016/1
8 years, 9 months ago (2012-03-15 14:16:33 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 15:59:17 UTC) #5
Change committed as 126922

Powered by Google App Engine
This is Rietveld 408576698