Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 9706001: [Mac] Add the OS version check functions for 10.8. (Closed)

Created:
8 years, 9 months ago by Robert Sesek
Modified:
8 years, 9 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

[Mac] Add the OS version check functions for 10.8. BUG=none TEST=Careful review by Mark. And a unittest. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126709

Patch Set 1 #

Total comments: 2

Patch Set 2 : IsOSDangerouslyLaterThanMountainLionForUseByCFAllocatorReplacement #

Total comments: 5

Patch Set 3 : IsOSMountainLionOrEarlier #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -4 lines) Patch
M base/mac/mac_util.h View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download
M base/mac/mac_util.mm View 1 2 3 4 chunks +27 lines, -2 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 1 2 3 3 chunks +30 lines, -2 lines 0 comments Download
M base/process_util_mac.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Robert Sesek
8 years, 9 months ago (2012-03-14 00:16:38 UTC) #1
Mark Mentovai
http://codereview.chromium.org/9706001/diff/1/base/mac/mac_util.h File base/mac/mac_util.h (right): http://codereview.chromium.org/9706001/diff/1/base/mac/mac_util.h#newcode146 base/mac/mac_util.h:146: BASE_EXPORT bool IsOSMountainLionOrEarlier(); This should not be present. Instead, ...
8 years, 9 months ago (2012-03-14 03:30:38 UTC) #2
Robert Sesek
http://codereview.chromium.org/9706001/diff/1/base/mac/mac_util.h File base/mac/mac_util.h (right): http://codereview.chromium.org/9706001/diff/1/base/mac/mac_util.h#newcode146 base/mac/mac_util.h:146: BASE_EXPORT bool IsOSMountainLionOrEarlier(); On 2012/03/14 03:30:38, Mark Mentovai wrote: ...
8 years, 9 months ago (2012-03-14 14:46:22 UTC) #3
Mark Mentovai
If we need to keep IsOSLaterThanLion to handle that one call site for now, OK, ...
8 years, 9 months ago (2012-03-14 15:24:52 UTC) #4
Robert Sesek
On 2012/03/14 15:24:52, Mark Mentovai wrote: > If we need to keep IsOSLaterThanLion to handle ...
8 years, 9 months ago (2012-03-14 15:35:20 UTC) #5
Robert Sesek
On 2012/03/14 15:24:52, Mark Mentovai wrote: > If we need to keep IsOSLaterThanLion to handle ...
8 years, 9 months ago (2012-03-14 15:37:45 UTC) #6
Mark Mentovai
The sole intent of the function is to test whether we know what the internals ...
8 years, 9 months ago (2012-03-14 15:49:10 UTC) #7
Robert Sesek
On 2012/03/14 15:49:10, Mark Mentovai wrote: > The sole intent of the function is to ...
8 years, 9 months ago (2012-03-14 16:11:12 UTC) #8
Mark Mentovai
Because we intentionally don’t expose MacOSXMinorVersion.
8 years, 9 months ago (2012-03-14 16:16:53 UTC) #9
Robert Sesek
IsOSDangerouslyLaterThanMountainLionForUseByCFAllocatorReplacement()
8 years, 9 months ago (2012-03-14 16:48:45 UTC) #10
Mark Mentovai
http://codereview.chromium.org/9706001/diff/5003/base/mac/mac_util.h File base/mac/mac_util.h (right): http://codereview.chromium.org/9706001/diff/5003/base/mac/mac_util.h#newcode146 base/mac/mac_util.h:146: BASE_EXPORT bool IsOSMountainLionOrEarlier(); xxx http://codereview.chromium.org/9706001/diff/5003/base/mac/mac_util.h#newcode193 base/mac/mac_util.h:193: inline bool IsOSMountainLionOrEarlier() ...
8 years, 9 months ago (2012-03-14 16:55:40 UTC) #11
Avi (use Gerrit)
On 2012/03/14 16:55:40, Mark Mentovai wrote: > Leave IsOSLaterThanLion in place for now, and then ...
8 years, 9 months ago (2012-03-14 16:59:22 UTC) #12
Avi (use Gerrit)
http://codereview.chromium.org/9706001/diff/2003/base/mac/mac_util.h File base/mac/mac_util.h (right): http://codereview.chromium.org/9706001/diff/2003/base/mac/mac_util.h#newcode152 base/mac/mac_util.h:152: bool IsOSDangerouslyLaterThanMountainLionForUseByCFAllocatorReplacement(); Alternatively, drop this and give me IsOSMountainLionOrEarlier().
8 years, 9 months ago (2012-03-14 17:00:52 UTC) #13
Robert Sesek
http://codereview.chromium.org/9706001/diff/5003/base/process_util_mac.mm File base/process_util_mac.mm (right): http://codereview.chromium.org/9706001/diff/5003/base/process_util_mac.mm#newcode721 base/process_util_mac.mm:721: return !base::mac::IsOSDangerouslyLaterThanMountainLionForUseByCFAllocatorReplacement(); On 2012/03/14 16:55:41, Mark Mentovai wrote: > ...
8 years, 9 months ago (2012-03-14 17:03:24 UTC) #14
Mark Mentovai
lgtm
8 years, 9 months ago (2012-03-14 17:37:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9706001/4002
8 years, 9 months ago (2012-03-14 17:41:07 UTC) #16
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 19:58:23 UTC) #17
Change committed as 126709

Powered by Google App Engine
This is Rietveld 408576698