Issue 9705092: Add IDS_ABOUT_CROS_VERSION_LICENSE support back to chrome://chrome

Issue 9705092: Add IDS_ABOUT_CROS_VERSION_LICENSE support back to chrome://chrome (Closed)

Created:
8 years, 9 months ago by Yusuke Sato

Modified:
8 years, 9 months ago

Reviewers:
James Hawkins, Evan Stade, Daniel Erat, arv (Not doing code reviews), csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add IDS_ABOUT_CROS_VERSION_LICENSE support back to chrome://chrome. BUG=118348, 119499 TEST=manually checked the following configurations: 1) Google Chrome for Chromebook (with USE=chrome_internal), 2) Chromium for Goobuntu with GYP_DEFINES=chromeos=1, 3) Chromium for Goobuntu without the GYP_DEFINES. TEST=git try -b linux_chromeos -c Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128152 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128738

Patch Set 1 #

Total comments: 1

Patch Set 2 : retry #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -21 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1	1 chunk	+5 lines, -10 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1	1 chunk	+4 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/help/help.html	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/help/help.js	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/help/help_handler.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 16 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

Please loop in Min Li Chan (mlchan) for the proposed UI change. http://codereview.chromium.org/9705092/diff/1/chrome/browser/resources/help/help.html File chrome/browser/resources/help/help.html ...

8 years, 9 months ago (2012-03-18 02:55:29 UTC) #4

Yusuke Sato

Contacted Min. I think Patch Set 1 already has the string Min suggested in http://code.google.com/p/chromium/issues/detail?id=118348#c6 ...

8 years, 9 months ago (2012-03-19 01:48:52 UTC) #5

Yusuke Sato

ping? On 2012/03/19 01:48:52, Yusuke Sato wrote: > Contacted Min. I think Patch Set 1 ...

8 years, 9 months ago (2012-03-20 23:42:27 UTC) #6

Yusuke Sato

+csilv, +estade, +arv (chrome/browser/resource/ and chrome/browser/ui/webui/ OWNERS) Could you do owners review? This is for ...

8 years, 9 months ago (2012-03-21 23:34:45 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9705092/1

8 years, 9 months ago (2012-03-22 01:33:33 UTC) #9

commit-bot: I haz the power

Failed to request the patch to try. Please note that binary filesare still unsupported at ...

8 years, 9 months ago (2012-03-22 01:34:30 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9705092/1

8 years, 9 months ago (2012-03-22 01:36:03 UTC) #11

Peter Mayo

On 2012/03/22 03:05:42, I haz the power (commit-bot) wrote: > Change committed as 128152 http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/5531 ...

8 years, 9 months ago (2012-03-22 18:45:29 UTC) #13

M-A Ruel

On 2012/03/22 01:34:30, I haz the power (commit-bot) wrote: > Failed to request the patch ...

8 years, 9 months ago (2012-03-22 19:14:36 UTC) #14

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9705092/20001

8 years, 9 months ago (2012-03-24 10:07:19 UTC) #15

Change committed as 128738

Expand Messages | Collapse Messages