Chromium Code Reviews| Index: chrome/renderer/print_web_view_helper_browsertest.cc |
| diff --git a/chrome/renderer/print_web_view_helper_browsertest.cc b/chrome/renderer/print_web_view_helper_browsertest.cc |
| index bc4f8a35bc2c039d1f2c2ab99fa4828d242eb0f1..75cb865848d43b1ea6789be21d136270d1268e0b 100644 |
| --- a/chrome/renderer/print_web_view_helper_browsertest.cc |
| +++ b/chrome/renderer/print_web_view_helper_browsertest.cc |
| @@ -188,8 +188,17 @@ TEST_F(PrintWebViewHelperTest, BlockScriptInitiatedPrinting) { |
| LoadHTML(kPrintWithJSHTML); |
| VerifyPagesPrinted(false); |
| - // Unblock script initiated printing and verify printing works. |
| + // Unblock based on count. |
| PrintWebViewHelper::Get(view_)->ResetScriptedPrintCount(); |
|
Lei Zhang
2012/03/19 20:19:32
You are missing a test here to make sure resetting
Albert Bodenhamer
2012/03/19 23:16:17
Good catch. I've split this into 2 different test
|
| + |
| + // Simulate a blocked popup. |
| + chrome_render_thread_->printer()->ResetPrinter(); |
| + chrome_render_thread_->printer()->SetScriptedPrintAllowed(false); |
| + LoadHTML(kPrintWithJSHTML); |
| + VerifyPagesPrinted(false); |
| + |
| + // Unblock and verify printing works. |
| + chrome_render_thread_->printer()->SetScriptedPrintAllowed(true); |
| chrome_render_thread_->printer()->ResetPrinter(); |
| LoadHTML(kPrintWithJSHTML); |
| VerifyPageCount(1); |