Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2219)

Unified Diff: chrome/common/extensions/manifest.cc

Issue 9705083: Unknown options in extension manifest file are silently ignored (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Changes per comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/manifest.h ('K') | « chrome/common/extensions/manifest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest.cc
diff --git a/chrome/common/extensions/manifest.cc b/chrome/common/extensions/manifest.cc
index 13f9e035442336f1bded25197123aad2a35d2cf6..ff2b7cd2d57b855a59b47eb7b1ca57be451419f4 100644
--- a/chrome/common/extensions/manifest.cc
+++ b/chrome/common/extensions/manifest.cc
@@ -25,7 +25,7 @@ Manifest::Manifest(Extension::Location location,
Manifest::~Manifest() {
}
-bool Manifest::ValidateManifest(string16* error) const {
+bool Manifest::ValidateManifest(string16* error) {
for (DictionaryValue::key_iterator key = value_->begin_keys();
key != value_->end_keys(); ++key) {
Feature* feature =
@@ -35,6 +35,7 @@ bool Manifest::ValidateManifest(string16* error) const {
// recognized for forward compatibility.
// TODO(aa): Consider having an error here in the case of strict error
// checking to let developers know when they screw up.
not at google - send to devlin 2012/04/30 02:32:36 You can remove the TODO now. Also, the comment abo
+ unrecognized_keys_.push_back(*key);
continue;
}
« chrome/common/extensions/manifest.h ('K') | « chrome/common/extensions/manifest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698