Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2081)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 9705083: Unknown options in extension manifest file are silently ignored (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Changes per comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 84b3ef0faafbdb6b8e960cdb062c02f8a70f8881..e0e5c3fb29183e21f44435a334c9ab0fc1265e82 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -186,11 +186,11 @@ cr.define('options', function() {
// Developer mode ////////////////////////////////////////////////////////
- // First we have the id.
+ // First, display the id.
var idLabel = node.querySelector('.extension-id');
idLabel.textContent = ' ' + extension.id;
- // Then the path, if provided by unpacked extension.
+ // Then, display the path, if provided by unpacked extension.
if (extension.isUnpacked) {
var loadPath = node.querySelector('.load-path');
loadPath.hidden = false;
@@ -198,11 +198,11 @@ cr.define('options', function() {
' ' + extension.path;
}
- // Then the 'managed, cannot uninstall/disable' message.
+ // Then, display the 'managed, cannot uninstall/disable' message.
if (!extension.mayDisable)
node.querySelector('.managed-message').hidden = false;
- // Then active views.
+ // Then, display active views.
if (extension.views.length > 0) {
var activeViews = node.querySelector('.active-views');
activeViews.hidden = false;
@@ -232,7 +232,7 @@ cr.define('options', function() {
});
}
- // The install warnings.
+ // Then, display install warnings.
if (extension.installWarnings) {
var panel = node.querySelector('.install-warnings');
panel.hidden = false;
@@ -242,6 +242,16 @@ cr.define('options', function() {
});
}
+ // Finally, display the unrecognized manifest keys.
+ if (extension.unrecognizedKeys) {
+ var unrecognizedKeys = node.querySelector('.unrecognized-keys');
+ unrecognizedKeys.hidden = false;
+ var list = unrecognizedKeys.querySelector('ul');
+ extension.unrecognizedKeys.forEach(function(key) {
+ list.appendChild(document.createElement('li')).innerText = key;
+ });
+ }
+
this.appendChild(node);
},
};

Powered by Google App Engine
This is Rietveld 408576698