Switch CreateSpdyHeadersFromHttpRequest to construct the correct headers based on the spdy protocol…

Send correct request headers when using spdy 3.

Require the spdy protocol version to be passed to   CreateSpdyHeadersFromHttpRequest so that the correct headers will be generated.

Add GetProtocolVersion methods to SpdyStream and SpdySession.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126950

[ramant (doing other things), 2012-03-15 05:41:34]

lgtm

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_http_utils.cc
File net/spdy/spdy_http_utils.cc (right):

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_http_utils.cc#new...
net/spdy/spdy_http_utils.cc:117: headers->erase("host"); // this is kinda
insane, spdy 3 spec
nit: this -> This. Period at the end of sentence (I think).

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_proxy_client_sock...
File net/spdy/spdy_proxy_client_socket.cc (right):

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_proxy_client_sock...
net/spdy/spdy_proxy_client_socket.cc:377: if (spdy_stream_->GetProtocolVersion()
> 2) {
nit: Please move comment left by 2 spaces. (duplicated comment?)

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_session_spdy2_uni...
File net/spdy/spdy_session_spdy2_unittest.cc (right):

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_session_spdy2_uni...
net/spdy/spdy_session_spdy2_unittest.cc:130:
ssl.SetNextProto(SSLClientSocket::kProtoSPDY21);
kProtoSPDY21 is this intentional? Could we use kProtoSPDY2 because it is SPDY/2
tests?

[commit-bot: I haz the power, 2012-03-15 16:17:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9705046/19

[Ryan Hamilton, 2012-03-15 16:38:06]

Thanks for the review, Raman.

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_http_utils.cc
File net/spdy/spdy_http_utils.cc (right):

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_http_utils.cc#new...
net/spdy/spdy_http_utils.cc:117: headers->erase("host"); // this is kinda
insane, spdy 3 spec
On 2012/03/15 05:41:34, ramant wrote:
> nit: this -> This. Period at the end of sentence (I think).

Done.

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_proxy_client_sock...
File net/spdy/spdy_proxy_client_socket.cc (right):

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_proxy_client_sock...
net/spdy/spdy_proxy_client_socket.cc:377: if (spdy_stream_->GetProtocolVersion()
> 2) {
On 2012/03/15 05:41:34, ramant wrote:
> nit: Please move comment left by 2 spaces. (duplicated comment?)

Done.

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_session_spdy2_uni...
File net/spdy/spdy_session_spdy2_unittest.cc (right):

http://codereview.chromium.org/9705046/diff/1/net/spdy/spdy_session_spdy2_uni...
net/spdy/spdy_session_spdy2_unittest.cc:130:
ssl.SetNextProto(SSLClientSocket::kProtoSPDY21);
On 2012/03/15 05:41:34, ramant wrote:
> kProtoSPDY21 is this intentional? Could we use kProtoSPDY2 because it is
SPDY/2
> tests?

Done.

[commit-bot: I haz the power, 2012-03-15 18:42:20]

Change committed as 126950