Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h

Issue 9705038: [Mac] Make ExtensionInstalledBubbleController is-a BaseBubbleController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
index 93fefd8046565a1d9b0b7fb961950f181bd0e5c0..b31d6c65757039ca08caded66225d4ffdc2a6596 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
@@ -11,6 +11,7 @@
#import "base/mac/cocoa_protocols.h"
#include "base/memory/scoped_ptr.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
+#import "chrome/browser/ui/cocoa/base_bubble_controller.h"
#include "third_party/skia/include/core/SkBitmap.h"
class Browser;
@@ -43,16 +44,14 @@ typedef enum {
kBundle,
} ExtensionType;
-}
+} // namespace extension_installed_bubble
// Controller for the extension installed bubble. This bubble pops up after
// an extension has been installed to inform the user that the install happened
// properly, and to let the user know how to manage this extension in the
// future.
-@interface ExtensionInstalledBubbleController :
- NSWindowController<NSWindowDelegate> {
+@interface ExtensionInstalledBubbleController : BaseBubbleController {
@private
- NSWindow* parentWindow_; // weak
const Extension* extension_; // weak
const extensions::BundleInstaller* bundle_; // weak
Browser* browser_; // weak
@@ -71,7 +70,6 @@ typedef enum {
scoped_ptr<ExtensionLoadedNotificationObserver> extensionObserver_;
// References below are weak, being obtained from the nib.
- IBOutlet InfoBubbleView* infoBubbleView_;
IBOutlet HoverCloseButton* closeButton_;
IBOutlet NSImageView* iconImage_;
IBOutlet NSTextField* extensionInstalledMsg_;
@@ -110,7 +108,7 @@ typedef enum {
@end
-@interface ExtensionInstalledBubbleController(ExposedForTesting)
+@interface ExtensionInstalledBubbleController (ExposedForTesting)
- (void)removePageActionPreviewIfNecessary;
- (NSWindow*)initializeWindow;

Powered by Google App Engine
This is Rietveld 408576698