Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 9705038: [Mac] Make ExtensionInstalledBubbleController is-a BaseBubbleController. (Closed)

Created:
8 years, 9 months ago by Robert Sesek
Modified:
8 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

[Mac] Make ExtensionInstalledBubbleController is-a BaseBubbleController. XIB changes: * Change ExtensionInstalledBubbleController to have BaseBubbleController as a parent class. * Set the bubble_ outlet on the new base class and delete infoBubbleView_. BUG=36366 TEST=Install an extension with a browser action. Bubble appears at browser action and behaves as before. TEST=Install bundled extensions and make sure the bubble appears at the wrench menu. TEST=Install an omnibox keyword extension and bubble appears at the lock icon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126919

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -462 lines) Patch
M chrome/app/nibs/ExtensionInstalledBubble.xib View 22 chunks +116 lines, -196 lines 0 comments Download
M chrome/app/nibs/ExtensionInstalledBubbleBundle.xib View 23 chunks +52 lines, -209 lines 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 5 chunks +12 lines, -51 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
Sorry for the hairy XIB diffs.
8 years, 9 months ago (2012-03-14 23:50:34 UTC) #1
Nico
LGTM description needs a "xib changes" section https://chromiumcodereview.appspot.com/9705038/diff/1/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm File chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm (right): https://chromiumcodereview.appspot.com/9705038/diff/1/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm#newcode251 chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm:251: self.anchorPoint = ...
8 years, 9 months ago (2012-03-14 23:59:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9705038/1
8 years, 9 months ago (2012-03-15 12:55:51 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 15:54:27 UTC) #4
Change committed as 126919

Powered by Google App Engine
This is Rietveld 408576698