chrome/common/net/gaia/oauth_request_signer.cc - Issue 9705024: [Coverity] Fix pass-by-val to pass-by-ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/net/gaia/oauth_request_signer.cc

Issue 9705024: [Coverity] Fix pass-by-val to pass-by-ref (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/net/gaia/oauth_request_signer.cc

diff --git a/chrome/common/net/gaia/oauth_request_signer.cc b/chrome/common/net/gaia/oauth_request_signer.cc

index a6bdf969fe862484a718f9fcae51e365fb55f949..81b750f7474f11704efcbb2dfe4f80b24cf7c7f8 100644

--- a/chrome/common/net/gaia/oauth_request_signer.cc

+++ b/chrome/common/net/gaia/oauth_request_signer.cc

@@ -78,7 +78,7 @@ const std::string SignatureMethodName(

std::string BuildBaseString(const GURL& request_base_url,

OAuthRequestSigner::HttpMethod http_method,

- const std::string base_parameters) {

+ const std::string& base_parameters) {

return StringPrintf("%s&%s&%s",

HttpMethodName(http_method).c_str(),

OAuthRequestSigner::Encode(

« no previous file with comments | « no previous file | no next file » | no next file with comments »