Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 9704057: Disable the optimizations replacing aggregates with scalars for Android (Closed)

Created:
8 years, 9 months ago by Peter Beverloo
Modified:
8 years, 9 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews, Yaron
Visibility:
Public.

Description

Disable the optimizations replacing aggregates with scalars for Android The optimizations may fail under certain conditions. This is the case in, for example, WebKit WTF's Checked type, and causes test failures. As this may affect more than just that code, disable it for the entirety of Chromium when building for Android. BUG= TEST=TestWebKitAPI passes all tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127262

Patch Set 1 #

Patch Set 2 : Patch #

Total comments: 2

Patch Set 3 : Emphasized on the NDK version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M build/common.gypi View 1 2 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Beverloo
8 years, 9 months ago (2012-03-15 17:46:29 UTC) #1
John Grabowski
LGTM https://chromiumcodereview.appspot.com/9704057/diff/1001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/9704057/diff/1001/build/common.gypi#newcode1959 build/common.gypi:1959: # compiler. This can be verified using TestWebKitAPI's ...
8 years, 9 months ago (2012-03-15 17:55:31 UTC) #2
Peter Beverloo
Done. Cheers! https://chromiumcodereview.appspot.com/9704057/diff/1001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/9704057/diff/1001/build/common.gypi#newcode1959 build/common.gypi:1959: # compiler. This can be verified using ...
8 years, 9 months ago (2012-03-15 18:00:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/9704057/4001
8 years, 9 months ago (2012-03-16 11:01:54 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-16 22:03:54 UTC) #5
Change committed as 127262

Powered by Google App Engine
This is Rietveld 408576698