Refactoring of code generation for declarations, in preparation for modules.

Refactoring of code generation for declarations, in preparation for modules.

Do proper dispatch on declaration type instead of mingling together
different code generation paths. Once we add more declaration forms,
this is more scalable.

In separate steps, I'd like to (1) clean up the logic for DeclareGlobal,
and (2) try to reduce the special handling of the name function var if
possible.

R=fschneider@chromium.org
BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=11331

[fschneider, 2012-04-11 11:00:42]

lgtm

https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-i...
File src/ia32/full-codegen-ia32.cc (right):

https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-i...
src/ia32/full-codegen-ia32.cc:272: != Variable::UNALLOCATED);
Break line after the operator to be consistent with the surrounding code.

Or since scope()->function() is used outside the ASSERT, you could also store it
in a local to make the line shorter.

https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-i...
src/ia32/full-codegen-ia32.cc:754: // The variable in the decl always resides in
the current function
s/decl/declaration/

https://chromiumcodereview.appspot.com/9704054/diff/1/src/parser.cc
File src/parser.cc (right):

https://chromiumcodereview.appspot.com/9704054/diff/1/src/parser.cc#newcode4450
src/parser.cc:4450: function_name, fvar_mode, true, Variable::NORMAL,
kCreatedInitialized);
Maybe break after each parameter and add a short same-line comment to the
boolean parameter.

https://chromiumcodereview.appspot.com/9704054/diff/1/src/scopes.cc
File src/scopes.cc (right):

https://chromiumcodereview.appspot.com/9704054/diff/1/src/scopes.cc#newcode423
src/scopes.cc:423: this, name, mode, true, Variable::NORMAL,
kCreatedInitialized);
Boolean parameter should have a comment.

[rossberg, 2012-04-16 11:25:13]

https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-i...
File src/ia32/full-codegen-ia32.cc (right):

https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-i...
src/ia32/full-codegen-ia32.cc:272: != Variable::UNALLOCATED);
On 2012/04/11 11:00:42, fschneider wrote:
> Break line after the operator to be consistent with the surrounding code.
> 
> Or since scope()->function() is used outside the ASSERT, you could also store
it
> in a local to make the line shorter.

Done (here and in other back-ends).

https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-i...
src/ia32/full-codegen-ia32.cc:754: // The variable in the decl always resides in
the current function
On 2012/04/11 11:00:42, fschneider wrote:
> s/decl/declaration/

Done (here and in other backends).

https://chromiumcodereview.appspot.com/9704054/diff/1/src/parser.cc
File src/parser.cc (right):

https://chromiumcodereview.appspot.com/9704054/diff/1/src/parser.cc#newcode4450
src/parser.cc:4450: function_name, fvar_mode, true, Variable::NORMAL,
kCreatedInitialized);
On 2012/04/11 11:00:42, fschneider wrote:
> Maybe break after each parameter and add a short same-line comment to the
> boolean parameter.

Done.

https://chromiumcodereview.appspot.com/9704054/diff/1/src/scopes.cc
File src/scopes.cc (right):

https://chromiumcodereview.appspot.com/9704054/diff/1/src/scopes.cc#newcode423
src/scopes.cc:423: this, name, mode, true, Variable::NORMAL,
kCreatedInitialized);
On 2012/04/11 11:00:42, fschneider wrote:
> Boolean parameter should have a comment.

Done.