Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 9704052: Position the Chrome OS Audio Player properly. (Closed)

Created:
8 years, 9 months ago by Vladislav Kaznacheev
Modified:
8 years, 9 months ago
Reviewers:
dgozman, SeRya
CC:
chromium-reviews, feature-media-reviews_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Position the Chrome OS Audio Player properly. This patch is trying to revive some of the behavior that the Audio Player had in the old panel manager, specifically it puts it in the lower right corner of the screen. This is likely to be a temporary solution. BUG=chromium-os:27701 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M chrome/browser/chromeos/media/media_player.cc View 4 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vladislav Kaznacheev
Please review.
8 years, 9 months ago (2012-03-15 10:34:22 UTC) #1
dgozman
I thought, this is supposed to be handled by aura window manager? If this is ...
8 years, 9 months ago (2012-03-15 10:37:54 UTC) #2
Vladislav Kaznacheev
On 2012/03/15 10:37:54, dgozman wrote: > I thought, this is supposed to be handled by ...
8 years, 9 months ago (2012-03-15 11:03:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9704052/1
8 years, 9 months ago (2012-03-15 11:04:33 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 13:18:57 UTC) #5
Change committed as 126900

Powered by Google App Engine
This is Rietveld 408576698