Issue 9704033: Fix two bugs in syntax highlighting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9704033: Fix two bugs in syntax highlighting (Closed)

Created:
8 years, 9 months ago by Brian Wilkerson

Modified:
8 years, 9 months ago

Reviewers:
messick

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+347 lines, -83 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/functions/FastDartPartitionScanner.java	View		6 chunks	+243 lines, -74 lines	0 comments	Download
	M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/functions/FastDartPartitionScannerTest.java	View		8 chunks	+104 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

messick

I'm concerned about performance. Have you tested this in a runtime workbench with the largest ...

8 years, 9 months ago (2012-03-14 20:57:47 UTC) #2

LGTM, following a rather impressive demo.