This patch modifies some aspects of GCAPI in support of the new Chrome reactivation functions.

chrome/installer/gcapi/gcapi.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NOTE: This code is a legacy utility API for partners to check whether
 //       Chrome can be installed and launched. Recent updates are being made
 //       to add new functionality. These updates use code from Chromium, the old
 //       coded against the win32 api directly. If you have an itch to shave a
 //       yak, feel free to re-write the old code too.
 
@@ skipping 551 matching lines @@
                                     DWORD* error_code) {
   DCHECK(error_code);
 
   if (!brand_code ||
       (previous_brand_codes_length > 0 && previous_brand_codes == NULL)) {
     if (error_code)
       *error_code = REACTIVATE_ERROR_INVALID_INPUT;
     return FALSE;
   }
 
-  bool has_system_install = IsChromeInstalled(HKEY_LOCAL_MACHINE);
-  bool has_user_install = IsChromeInstalled(HKEY_CURRENT_USER);
-
-  if (!has_system_install && !has_user_install) {
-    if (error_code)
-      *error_code = REACTIVATE_ERROR_NOTINSTALLED;
-    return FALSE;
-  }
-
   int days_since_last_run = GoogleChromeDaysSinceLastRun();
   if (days_since_last_run >= 0 &&
       days_since_last_run < kReactivationMinDaysDormant) {
     if (error_code)
       *error_code = REACTIVATE_ERROR_NOTDORMANT;
     return FALSE;
   }
 
-  // Make sure we haven't previously been reactivated by this brand code
-  // or any of the previous brand codes from this partner.
-  // Since this function is invoked by ReactivateChrome, and since
-  // ReactivateChrome is called first in non-elevated shell and
-  // second in UAC-elevated shell, we only want to execute this block
-  // of code the first time, in non-elevated mode.
+  // Only run the code below when this function is invoked from a standard,
+  // non-elevated cmd shell.  This is because this section of code looks at
+  // values in HKEY_CURRENT_USER, and we only want to look at the logged-in
+  // user's HKCU, not the admin user's HKCU.
   if (shell_mode == GCAPI_INVOKED_STANDARD_SHELL) {
+    bool has_system_install = IsChromeInstalled(HKEY_LOCAL_MACHINE);
+    bool has_user_install = IsChromeInstalled(HKEY_CURRENT_USER);

[robertshield, 2012/03/23 17:52:16]

for brevity, consider deleting these temp variables and placing the
IsChromeInstalled() calls directly in the if statement below.

[mgraboski, 2012/03/23 21:40:35]

Done.

+
+    if (!has_system_install && !has_user_install) {
+      if (error_code)
+        *error_code = REACTIVATE_ERROR_NOTINSTALLED;
+      return FALSE;
+    }
+
     std::vector<std::wstring> reactivation_brands;
     reactivation_brands.push_back(brand_code);
     if (previous_brand_codes_length > 0 && previous_brand_codes != NULL) {
       std::copy(previous_brand_codes,
                 previous_brand_codes + previous_brand_codes_length,
                 std::back_inserter(reactivation_brands));
     }

[robertshield, 2012/03/23 17:52:16]

you can delete the above 7 lines if reactivation_brands is no longer used.

[mgraboski, 2012/03/23 21:40:35]

Done.

-    if (HasBeenReactivatedByBrandCodes(reactivation_brands)) {
+    if (HasBeenReactivated()) {
       if (error_code)
         *error_code = REACTIVATE_ERROR_ALREADY_REACTIVATED;
       return FALSE;
     }
   }
 
   return TRUE;
 }
 
 BOOL __stdcall ReactivateChrome(wchar_t* brand_code,
@@ skipping 15 matching lines @@
       result = TRUE;
     } else {
       if (error_code)
         *error_code = REACTIVATE_ERROR_REACTIVATION_FAILED;
     }
   }
 
   return result;
 }