Add DeviceSettingProvider unit tests.

chrome/browser/chromeos/device_settings_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/device_settings_provider.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/file_util.h"
@@ skipping 63 matching lines @@
   // If the value is not set we should try to migrate legacy consent file.
   // Loading consent file state causes us to do blocking IO on UI thread.
   // Temporarily allow it until we fix http://crbug.com/62626
   base::ThreadRestrictions::ScopedAllowIO allow_io;
   return GoogleUpdateSettings::GetCollectStatsConsent();
 }
 
 }  // namespace
 
 DeviceSettingsProvider::DeviceSettingsProvider(
+    const NotifyObserversCallback& notify_cb,
+    SignedSettingsHelper* signed_settings_helper,
+    OwnershipService::Status ownership_status)
+    : CrosSettingsProvider(notify_cb),
+      signed_settings_helper_(signed_settings_helper),
+      ownership_status_(ownership_status),
+      migration_helper_(new SignedSettingsMigrationHelper()),
+      retries_left_(kNumRetriesLimit),
+      trusted_(false) {
+  Initialize();
+}
+
+DeviceSettingsProvider::DeviceSettingsProvider(
     const NotifyObserversCallback& notify_cb)
     : CrosSettingsProvider(notify_cb),
+      signed_settings_helper_(SignedSettingsHelper::Get()),
       ownership_status_(OwnershipService::GetSharedInstance()->GetStatus(true)),
       migration_helper_(new SignedSettingsMigrationHelper()),
       retries_left_(kNumRetriesLimit),
       trusted_(false) {
+  Initialize();
+}
+
+DeviceSettingsProvider::~DeviceSettingsProvider() {
+}
+
+void DeviceSettingsProvider::Initialize() {
   // Register for notification when ownership is taken so that we can update
   // the |ownership_status_| and reload if needed.
   registrar_.Add(this, chrome::NOTIFICATION_OWNER_KEY_FETCH_ATTEMPT_SUCCEEDED,
                  content::NotificationService::AllSources());
   // Make sure we have at least the cache data immediately.
   RetrieveCachedData();
   // Start prefetching preferences.
   Reload();
 }
 
-DeviceSettingsProvider::~DeviceSettingsProvider() {
-}
-
 void DeviceSettingsProvider::Reload() {
   // While fetching we can't trust the cache anymore.
   trusted_ = false;
   if (ownership_status_ == OwnershipService::OWNERSHIP_NONE) {
     RetrieveCachedData();
   } else {
     // Retrieve the real data.
-    SignedSettingsHelper::Get()->StartRetrievePolicyOp(
+    signed_settings_helper_->StartRetrievePolicyOp(
         base::Bind(&DeviceSettingsProvider::OnRetrievePolicyCompleted,
                    base::Unretained(this)));
   }
 }
 
 void DeviceSettingsProvider::DoSet(const std::string& path,
                                    const base::Value& in_value) {
   if (!UserManager::Get()->IsCurrentUserOwner() &&
       ownership_status_ != OwnershipService::OWNERSHIP_NONE) {
     LOG(WARNING) << "Changing settings from non-owner, setting=" << path;
@@ skipping 66 matching lines @@
       if (!pending_changes_.empty())
         SetInPolicy();
     } else {
       NOTREACHED();
     }
     return;
   }
 
   if (!RequestTrustedEntity()) {
     // Otherwise we should first reload and apply on top of that.
-    SignedSettingsHelper::Get()->StartRetrievePolicyOp(
+    signed_settings_helper_->StartRetrievePolicyOp(
         base::Bind(&DeviceSettingsProvider::FinishSetInPolicy,
                    base::Unretained(this)));
     return;
   }
 
   trusted_ = false;
   em::PolicyData data = policy();
   em::ChromeDeviceSettingsProto pol;
   pol.ParseFromString(data.policy_value());
   if (prop == kAccountsPrefAllowNewUser) {
@@ skipping 88 matching lines @@
   // Set the cache to the updated value.
   policy_ = data;
   UpdateValuesCache();
 
   if (!signed_settings_cache::Store(data, g_browser_process->local_state()))
     LOG(ERROR) << "Couldn't store to the temp storage.";
 
   if (ownership_status_ == OwnershipService::OWNERSHIP_TAKEN) {
     em::PolicyFetchResponse policy_envelope;
     policy_envelope.set_policy_data(policy_.SerializeAsString());
-    SignedSettingsHelper::Get()->StartStorePolicyOp(
+    signed_settings_helper_->StartStorePolicyOp(
         policy_envelope,
         base::Bind(&DeviceSettingsProvider::OnStorePolicyCompleted,
                    base::Unretained(this)));
   } else {
     // OnStorePolicyCompleted won't get called in this case so proceed with any
     // pending operations immediately.
     delete pending_changes_[0].second;
     pending_changes_.erase(pending_changes_.begin());
     if (!pending_changes_.empty())
       SetInPolicy();
@@ skipping 405 matching lines @@
         Reload();
         return;
       }
       LOG(ERROR) << "No retries left";
       break;
     }
   }
 }
 
 }  // namespace chromeos