Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Unified Diff: chrome/browser/command_updater.h

Issue 9703099: Revert 126959 - Re-factor location bar/toolbar code to get rid of the browser dependency. This CL i… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/command_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/command_updater.h
===================================================================
--- chrome/browser/command_updater.h (revision 127082)
+++ chrome/browser/command_updater.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -8,7 +8,6 @@
#include "base/basictypes.h"
#include "base/hash_tables.h"
-#include "webkit/glue/window_open_disposition.h"
////////////////////////////////////////////////////////////////////////////////
//
@@ -24,11 +23,8 @@
// when needed.
class CommandUpdaterDelegate {
public:
- // Performs the action associated with the command with the specified ID and
- // using the given disposition.
- virtual void ExecuteCommandWithDisposition(
- int id,
- WindowOpenDisposition disposition) = 0;
+ // Perform the action associated with the command with the specified ID.
+ virtual void ExecuteCommand(int id) = 0;
protected:
virtual ~CommandUpdaterDelegate();
@@ -46,19 +42,11 @@
// supported by this updater.
bool IsCommandEnabled(int id) const;
- // Performs the action associated with this command ID using CURRENT_TAB
- // disposition.
+ // Performs the action associated with this command ID.
// TODO(beng): get rid of this since it's effectively just a pass-thru and the
// call sites would be better off using more well defined delegate interfaces.
void ExecuteCommand(int id);
- // Performs the action associated with this command ID using the given
- // disposition.
- // TODO(altimofeev): refactor the interface to provide more flexible and
- // explicit way for passing command specific arguments. See
- // NotificationDetails class for the possible implementation ideas.
- void ExecuteCommandWithDisposition(int id, WindowOpenDisposition disposition);
-
// An Observer interface implemented by objects that want to be informed when
// the state of a particular command ID is modified.
class CommandObserver {
« no previous file with comments | « no previous file | chrome/browser/command_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698