Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 9703098: Remove "base/values.h" import from "base/location.h", fix up downstream files. (Closed)

Created:
8 years, 9 months ago by Ilya Sherman
Modified:
8 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, amit, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dmazzoni+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, wez+watch_chromium.org, sanjeevr, yuzo+watch_chromium.org, simonmorris+watch_chromium.org, sergeyu+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, hashimoto+watch_chromium.org, davidbarr+watch_chromium.org, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, dtseng+watch_chromium.org, alexeypa+watch_chromium.org, mmenke
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Revert unrelated change #

Patch Set 3 : Fix a couple more files #

Patch Set 4 : Fix one more file on ChromiumOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M base/location.h View 1 chunk +4 lines, -1 line 0 comments Download
M base/location.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_test.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_system_task_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/dns/dns_transaction.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/mock_client_socket_pool_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.h View 2 chunks +5 lines, -1 line 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Elliot Glaysher
lgtm
8 years, 9 months ago (2012-03-16 00:59:14 UTC) #1
Ilya Sherman
TBR'ing owners, as the patch is trivial -- just fixing up includes.
8 years, 9 months ago (2012-03-16 01:02:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/9703098/2001
8 years, 9 months ago (2012-03-16 01:23:54 UTC) #3
commit-bot: I haz the power
Try job failure for 9703098-2001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-16 03:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/9703098/1022
8 years, 9 months ago (2012-03-16 05:33:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/9703098/13002
8 years, 9 months ago (2012-03-16 05:48:20 UTC) #6
commit-bot: I haz the power
Try job failure for 9703098-13002 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-16 08:06:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/9703098/13002
8 years, 9 months ago (2012-03-16 19:33:29 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-16 21:43:44 UTC) #9
Change committed as 127256

Powered by Google App Engine
This is Rietveld 408576698