Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 9703084: [Mac] Make BookmarkBubbleController is-a BaseBubbleController. (Closed)

Created:
8 years, 9 months ago by Robert Sesek
Modified:
8 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Make BookmarkBubbleController is-a BaseBubbleController. XIB changes: * Update the base class for BookmarkBubbleController to reflect new outlet location. BUG=116179 TEST=Click the star icon in the omnibox. You can edit bookmarks. TEST=Covered by unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127200

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -85 lines) Patch
M chrome/app/nibs/BookmarkBubble.xib View 7 chunks +29 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 7 chunks +27 lines, -56 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Robert Sesek
Last one!
8 years, 9 months ago (2012-03-15 21:08:05 UTC) #1
Nico
lgtm https://chromiumcodereview.appspot.com/9703084/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right): https://chromiumcodereview.appspot.com/9703084/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm#newcode177 chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:177: // unfortunately, [NSWindowController showWindow:] will also bring it ...
8 years, 9 months ago (2012-03-15 21:21:34 UTC) #2
Robert Sesek
https://chromiumcodereview.appspot.com/9703084/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right): https://chromiumcodereview.appspot.com/9703084/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm#newcode177 chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:177: // unfortunately, [NSWindowController showWindow:] will also bring it On ...
8 years, 9 months ago (2012-03-16 15:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9703084/5001
8 years, 9 months ago (2012-03-16 15:31:16 UTC) #4
commit-bot: I haz the power
Try job failure for 9703084-5001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-16 16:19:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9703084/5001
8 years, 9 months ago (2012-03-16 16:22:51 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-16 18:01:10 UTC) #7
Change committed as 127200

Powered by Google App Engine
This is Rietveld 408576698