Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 9703067: mac: Move EventWithMenuAction() to the only file where it's called. (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
Reviewers:
tony
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

mac: Move EventWithMenuAction() to the only file where it's called. This way, it doesn't cross module boundaries. BUG=90078 TEST=none NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -72 lines) Patch
M webkit/glue/webmenurunner_mac.h View 1 chunk +0 lines, -12 lines 0 comments Download
M webkit/glue/webmenurunner_mac.mm View 1 chunk +0 lines, -58 lines 0 comments Download
M webkit/tools/test_shell/mac/test_webview_delegate.mm View 2 chunks +59 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
8 years, 9 months ago (2012-03-15 16:49:36 UTC) #1
tony
LGTM
8 years, 9 months ago (2012-03-15 17:06:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9703067/1
8 years, 9 months ago (2012-03-15 17:14:43 UTC) #3
commit-bot: I haz the power
Try job failure for 9703067-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-15 19:24:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9703067/1
8 years, 9 months ago (2012-03-15 19:42:32 UTC) #5
commit-bot: I haz the power
Try job failure for 9703067-1 (retry) (retry) (previous was lost) on win_rel for step "compile" ...
8 years, 9 months ago (2012-03-16 01:22:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9703067/1
8 years, 9 months ago (2012-03-16 01:34:43 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-16 02:00:23 UTC) #8
Change committed as 127082

Powered by Google App Engine
This is Rietveld 408576698