SPDY - don't persist SpdySettings until we convert it to a map.

chrome/browser/net/http_server_properties_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/net/http_server_properties_manager.h"
 
 #include "base/bind.h"
 #include "base/stl_util.h"
 #include "base/values.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/common/chrome_notification_types.h"
@@ skipping 260 matching lines @@
       continue;
     }
 
     // Get if server supports Spdy.
     bool supports_spdy = false;
     if ((server_pref_dict->GetBoolean(
          "supports_spdy", &supports_spdy)) && supports_spdy) {
       spdy_servers->push_back(server_str);
     }
 
-    // Get SpdySettings.
+    // TODO(rtenneti): Implement reading of SpdySettings.
     DCHECK(!ContainsKey(*spdy_settings_map, server));
-    base::ListValue* spdy_settings_list = NULL;
-    if (server_pref_dict->GetListWithoutPathExpansion(
-        "settings", &spdy_settings_list)) {
-      spdy::SpdySettings spdy_settings;
-
-      for (base::ListValue::const_iterator list_it =
-           spdy_settings_list->begin();
-           list_it != spdy_settings_list->end(); ++list_it) {
-        if ((*list_it)->GetType() != Value::TYPE_DICTIONARY) {
-          DVLOG(1) << "Malformed SpdySettingsList for server: " << server_str;
-          detected_corrupted_prefs = true;
-          continue;
-        }
-
-        const base::DictionaryValue* spdy_setting_dict =
-            static_cast<const base::DictionaryValue*>(*list_it);
-
-        int id = 0;
-        if (!spdy_setting_dict->GetIntegerWithoutPathExpansion("id", &id)) {
-          DVLOG(1) << "Malformed id in SpdySettings for server: " << server_str;
-          detected_corrupted_prefs = true;
-          continue;
-        }
-
-        int value = 0;
-        if (!spdy_setting_dict->GetIntegerWithoutPathExpansion("value",
-                                                               &value)) {
-          DVLOG(1) << "Malformed value in SpdySettings for server: " <<
-              server_str;
-          detected_corrupted_prefs = true;
-          continue;
-        }
-
-        spdy::SettingsFlagsAndId flags_and_id(
-            spdy::SETTINGS_FLAG_PERSISTED, id);
-        spdy_settings.push_back(spdy::SpdySetting(flags_and_id, value));
-      }
-
-      (*spdy_settings_map)[server] = spdy_settings;
-    }
 
     int pipeline_capability = net::PIPELINE_UNKNOWN;
     if ((server_pref_dict->GetInteger(
          "pipeline_capability", &pipeline_capability)) &&
         pipeline_capability != net::PIPELINE_UNKNOWN) {
       (*pipeline_capability_map)[server] =
           static_cast<net::HttpPipelinedHostCapability>(pipeline_capability);
     }
 
     // Get alternate_protocol server.
@@ skipping 235 matching lines @@
        server_pref_map.begin();
        map_it != server_pref_map.end(); ++map_it) {
     const net::HostPortPair& server = map_it->first;
     const ServerPref& server_pref = map_it->second;
 
     base::DictionaryValue* server_pref_dict = new base::DictionaryValue;
 
     // Save supports_spdy.
     server_pref_dict->SetBoolean("supports_spdy", server_pref.supports_spdy);
 
-    // Save SpdySettings.
-    if (server_pref.settings) {
-      base::ListValue* spdy_settings_list = new ListValue();
-      for (spdy::SpdySettings::const_iterator it =
-           server_pref.settings->begin();
-           it != server_pref.settings->end(); ++it) {
-        uint32 id = it->first.id();
-        uint32 value = it->second;
-        base::DictionaryValue* spdy_setting_dict = new base::DictionaryValue;
-        spdy_setting_dict->SetInteger("id", id);
-        spdy_setting_dict->SetInteger("value", value);
-        spdy_settings_list->Append(spdy_setting_dict);
-      }
-      server_pref_dict->Set("settings", spdy_settings_list);
-    }
+    // TODO(rtenneti): Implement save SpdySettings.
 
     // Save alternate_protocol.
     if (server_pref.alternate_protocol) {
       base::DictionaryValue* port_alternate_protocol_dict =
           new base::DictionaryValue;
       const net::PortAlternateProtocolPair* port_alternate_protocol =
           server_pref.alternate_protocol;
       port_alternate_protocol_dict->SetInteger(
           "port", port_alternate_protocol->port);
       port_alternate_protocol_dict->SetInteger(
@@ skipping 28 matching lines @@
   std::string* pref_name = content::Details<std::string>(details).ptr();
   if (*pref_name == prefs::kHttpServerProperties) {
     if (!setting_prefs_)
       ScheduleUpdateCacheOnUI();
   } else {
     NOTREACHED();
   }
 }
 
 }  // namespace chrome_browser_net