Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4115)

Unified Diff: chrome/browser/resources/options/pack_extension_overlay.js

Issue 9703039: Extensions: Don't pass the selected unpacked extension path from JS to C++ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/pack_extension_overlay.js
diff --git a/chrome/browser/resources/options/pack_extension_overlay.js b/chrome/browser/resources/options/pack_extension_overlay.js
index f4b962ae1fb3ceb817ed9948f00270eca9dc266c..6135710abc6e8b93f7a77ce4bdd842a8cd0c0724 100644
--- a/chrome/browser/resources/options/pack_extension_overlay.js
+++ b/chrome/browser/resources/options/pack_extension_overlay.js
@@ -47,17 +47,19 @@ cr.define('options', function() {
* Utility function which asks the C++ to show a platform-specific file
* select dialog, and fire |callback| with the |filePath| that resulted.
* |selectType| can be either 'file' or 'folder'. |operation| can be 'load',
- * 'packRoot', or 'pem' which are signals to the C++ to do some
- * operation-specific configuration.
+ * or 'pem' which are signals to the C++ to do some operation-specific
+ * configuration.
* @private
*/
showFileDialog_: function(selectType, operation, callback) {
- handleFilePathSelected = function(filePath) {
+ // |window.handleFilePathSelected| will be called from the C++ handler
+ // once the user selects a path.
+ window.handleFilePathSelected = function(filePath) {
callback(filePath);
handleFilePathSelected = function() {};
};
- chrome.send('extensionSettingsSelectFilePath', [selectType, operation]);
+ chrome.send('packExtensionSelectFilePath', [selectType, operation]);
},
/**

Powered by Google App Engine
This is Rietveld 408576698