Extensions: Don't pass the selected unpacked extension path from JS to C++

chrome/browser/resources/options/pack_extension_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
 
   /**
    * PackExtensionOverlay class
    * Encapsulated handling of the 'Pack Extension' overlay page.
@@ skipping 29 matching lines @@
       $('browseExtensionDir').addEventListener('click',
           this.handleBrowseExtensionDir_.bind(this));
       $('browsePrivateKey').addEventListener('click',
           this.handleBrowsePrivateKey_.bind(this));
     },
 
     /**
     * Utility function which asks the C++ to show a platform-specific file
     * select dialog, and fire |callback| with the |filePath| that resulted.
     * |selectType| can be either 'file' or 'folder'. |operation| can be 'load',
-    * 'packRoot', or 'pem' which are signals to the C++ to do some
-    * operation-specific configuration.
+    * or 'pem' which are signals to the C++ to do some operation-specific
+    * configuration.
     * @private
     */
     showFileDialog_: function(selectType, operation, callback) {
-      handleFilePathSelected = function(filePath) {
+      // |window.handleFilePathSelected| will be called from the C++ handler
+      // once the user selects a path.
+      window.handleFilePathSelected = function(filePath) {
         callback(filePath);
         handleFilePathSelected = function() {};
       };
 
-      chrome.send('extensionSettingsSelectFilePath', [selectType, operation]);
+      chrome.send('packExtensionSelectFilePath', [selectType, operation]);
     },
 
     /**
      * Handles the showing of the extension directory browser.
      * @param {Event} e Change event.
      * @private
      */
     handleBrowseExtensionDir_: function(e) {
       this.showFileDialog_('folder', 'load', function(filePath) {
         $('extensionRootDir').value = filePath;
@@ skipping 38 matching lines @@
         OptionsPage.closeOverlay();
         OptionsPage.showPageByName('packExtensionOverlay', false);
       }, null);
   }
 
   // Export
   return {
     PackExtensionOverlay: PackExtensionOverlay
   };
 });