Extensions: Don't pass the selected unpacked extension path from JS to C++

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js"></include>
 <include src="extension_list.js"></include>
 <include src="pack_extension_overlay.js"></include>
 
 // Used for observing function of the backend datasource for this page by
 // tests.
@@ skipping 49 matching lines @@
 
       var packExtensionOverlay = extensions.PackExtensionOverlay.getInstance();
       packExtensionOverlay.initializePage();
 
       // Trigger the scroll handler to tell the navigation if our page started
       // with some scroll (happens when you use tab restore).
       this.handleScroll_();
     },
 
     /**
-     * Utility function which asks the C++ to show a platform-specific file
-     * select dialog, and fire |callback| with the |filePath| that resulted.
-     * |selectType| can be either 'file' or 'folder'. |operation| can be 'load',
-     * 'packRoot', or 'pem' which are signals to the C++ to do some
-     * operation-specific configuration.
-     * @private
-     */
-    showFileDialog_: function(selectType, operation, callback) {
-      handleFilePathSelected = function(filePath) {
-        callback(filePath);
-        handleFilePathSelected = function() {};
-      };
-
-      chrome.send('extensionSettingsSelectFilePath', [selectType, operation]);
-    },
-
-    /**
      * Handles the Load Unpacked Extension button.
      * @param {Event} e Change event.
      * @private
      */
     handleLoadUnpackedExtension_: function(e) {
-      this.showFileDialog_('folder', 'pem', function(filePath) {
-        chrome.send('extensionSettingsLoad', [String(filePath)]);
-      });
+      chrome.send('extensionSettingsLoadUnpackedExtension');
 
+      // TODO(jhawkins): Refactor metrics support out of options and use it

[Evan Stade, 2012/03/14 23:13:45]

MetricsHandler

[James Hawkins, 2012/03/15 00:24:13]

I meant pull it out of pref_ui.js so we can add metric="blah" to buttons
declaratively.

+      // in extensions.html.
       chrome.send('coreOptionsUserMetricsAction',
                   ['Options_LoadUnpackedExtension']);
     },
 
     /**
      * Handles the Pack Extension button.
      * @param {Event} e Change event.
      * @private
      */
     handlePackExtension_: function(e) {
@@ skipping 142 matching lines @@
     ExtensionSettings: ExtensionSettings
   };
 });
 
 var ExtensionSettings = extensions.ExtensionSettings;
 
 // 'load' seems to have a bad interaction with open_sans.woff.
 window.addEventListener('DOMContentLoaded', function(e) {
   ExtensionSettings.getInstance().initialize();
 });