Issue 9703022: Set valid profile image when logging in as demo user

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9703022: Set valid profile image when logging in as demo user (Closed)

Created:
8 years, 9 months ago by use bartfab instead

Modified:
8 years, 9 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, pastarmovj, rkc

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Set valid profile image when logging in as demo user This CL ensures that a valid profile image is set when a demo user logs in. Additionally, the code paths taken by UserManager::LoggedIn() for the different classes of users are cleaned up a bit. BUG=chromium-os:27645 TEST=unittest UserManagerTest* TEST=manual login test in a Chromium OS VM Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126906

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -32 lines)			Patch
M	chrome/browser/chromeos/login/mock_user_manager.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View	2 chunks	+40 lines, -32 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

use bartfab instead

Hi Nikita, could you review this retail mode fix-up when you get a chance?

8 years, 9 months ago (2012-03-14 12:37:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@google.com/9703022/1

8 years, 9 months ago (2012-03-15 11:56:39 UTC) #4

Change committed as 126906

Expand Messages | Collapse Messages