Move the cookie store implementation into its own directory.

Move the cookie store implementation into its own directory.

In the initial step, forwarding headers are left in net/base/cookie_*h . After all clients are updated these will be removed and erikwright will be removed from net/base/OWNERS

BUG=70818
TEST=compilation


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126871

[erikwright (departed), 2012-03-14 03:58:44]

Hi Will,

Alternatively, this stuff could go into net/cookies or net/http/cookies . WDYT?

Besides the fact that there's already a lot of stuff here, I want to begin some
gradual refactoring, separation of concerns, decoupling, encapsulation, etc.,
and I don't want to be hindered by concerns of further crowding net/base.

Also, I get code-review requests for net/base that I am not qualified for.

Thanks,

Erik

[willchan no longer on Chromium, 2012-03-14 09:51:36]

Thanks for not crowding net/base. I'm in favor of net/cookies. I'd like to
hear from wtc too though before proceeding. I will chat with him tomorrow
unless he chimes in here first.

On Tue, Mar 13, 2012 at 8:58 PM, <erikwright@chromium.org> wrote:

> Reviewers: willchan,
>
> Message:
> Hi Will,
>
> Alternatively, this stuff could go into net/cookies or net/http/cookies .
> WDYT?
>
> Besides the fact that there's already a lot of stuff here, I want to begin
> some
> gradual refactoring, separation of concerns, decoupling, encapsulation,
> etc.,
> and I don't want to be hindered by concerns of further crowding net/base.
>
> Also, I get code-review requests for net/base that I am not qualified for.
>
> Thanks,
>
> Erik
>
> Description:
> Move the cookie store implementation into its own directory.
>
> In the initial step, forwarding headers are left in net/base/cookie_*h .
> After
> all clients are updated these will be removed and erikwright will be
> removed
> from net/base/OWNERS
>
> BUG=None
> TEST=compilation
>
>
> Please review this at
http://codereview.chromium.**org/9703011/<http://codereview.chromium.org/9703...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M net/base/cookie_monster.h
>  D net/base/cookie_monster.cc
>  D net/base/cookie_monster_**perftest.cc
>  M net/base/cookie_monster_store_**test.h
>  D net/base/cookie_monster_store_**test.cc
>  D net/base/cookie_monster_**unittest.cc
>  M net/base/cookie_options.h
>  M net/base/cookie_store.h
>  D net/base/cookie_store.cc
>  M net/base/cookie_store_test_**callbacks.h
>  D net/base/cookie_store_test_**callbacks.cc
>  M net/base/cookie_store_test_**helpers.h
>  D net/base/cookie_store_test_**helpers.cc
>  M net/base/cookie_store_**unittest.h
>  M net/base/cookie_util.h
>  D net/base/cookie_util.cc
>  D net/base/cookie_util_unittest.**cc
>  A net/base/cookies/OWNERS
>  A + net/base/cookies/cookie_**monster.h
>  A + net/base/cookies/cookie_**monster.cc
>  A + net/base/cookies/cookie_**monster_perftest.cc
>  A + net/base/cookies/cookie_**monster_store_test.h
>  A + net/base/cookies/cookie_**monster_store_test.cc
>  A + net/base/cookies/cookie_**monster_unittest.cc
>  A + net/base/cookies/cookie_**options.h
>  A + net/base/cookies/cookie_store.**h
>  A + net/base/cookies/cookie_store.**cc
>  A + net/base/cookies/cookie_store_**test_callbacks.h
>  A + net/base/cookies/cookie_store_**test_callbacks.cc
>  A + net/base/cookies/cookie_store_**test_helpers.h
>  A + net/base/cookies/cookie_store_**test_helpers.cc
>  A + net/base/cookies/cookie_store_**unittest.h
>  A + net/base/cookies/cookie_util.h
>  A + net/base/cookies/cookie_util.**cc
>  A + net/base/cookies/cookie_util_**unittest.cc
>  M net/net.gyp
>
>
>

[willchan no longer on Chromium, 2012-03-14 17:06:59]

I chatted with wtc and we agreed on net/cookies. Thanks!

On Wed, Mar 14, 2012 at 2:51 AM, William Chan (陈智昌)
<willchan@chromium.org>wrote:

> Thanks for not crowding net/base. I'm in favor of net/cookies. I'd like to
> hear from wtc too though before proceeding. I will chat with him tomorrow
> unless he chimes in here first.
>
>
> On Tue, Mar 13, 2012 at 8:58 PM, <erikwright@chromium.org> wrote:
>
>> Reviewers: willchan,
>>
>> Message:
>> Hi Will,
>>
>> Alternatively, this stuff could go into net/cookies or net/http/cookies .
>> WDYT?
>>
>> Besides the fact that there's already a lot of stuff here, I want to
>> begin some
>> gradual refactoring, separation of concerns, decoupling, encapsulation,
>> etc.,
>> and I don't want to be hindered by concerns of further crowding net/base.
>>
>> Also, I get code-review requests for net/base that I am not qualified for.
>>
>> Thanks,
>>
>> Erik
>>
>> Description:
>> Move the cookie store implementation into its own directory.
>>
>> In the initial step, forwarding headers are left in net/base/cookie_*h .
>> After
>> all clients are updated these will be removed and erikwright will be
>> removed
>> from net/base/OWNERS
>>
>> BUG=None
>> TEST=compilation
>>
>>
>> Please review this at
http://codereview.chromium.**org/9703011/<http://codereview.chromium.org/9703...
>>
>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>>
>> Affected files:
>>  M net/base/cookie_monster.h
>>  D net/base/cookie_monster.cc
>>  D net/base/cookie_monster_**perftest.cc
>>  M net/base/cookie_monster_store_**test.h
>>  D net/base/cookie_monster_store_**test.cc
>>  D net/base/cookie_monster_**unittest.cc
>>  M net/base/cookie_options.h
>>  M net/base/cookie_store.h
>>  D net/base/cookie_store.cc
>>  M net/base/cookie_store_test_**callbacks.h
>>  D net/base/cookie_store_test_**callbacks.cc
>>  M net/base/cookie_store_test_**helpers.h
>>  D net/base/cookie_store_test_**helpers.cc
>>  M net/base/cookie_store_**unittest.h
>>  M net/base/cookie_util.h
>>  D net/base/cookie_util.cc
>>  D net/base/cookie_util_unittest.**cc
>>  A net/base/cookies/OWNERS
>>  A + net/base/cookies/cookie_**monster.h
>>  A + net/base/cookies/cookie_**monster.cc
>>  A + net/base/cookies/cookie_**monster_perftest.cc
>>  A + net/base/cookies/cookie_**monster_store_test.h
>>  A + net/base/cookies/cookie_**monster_store_test.cc
>>  A + net/base/cookies/cookie_**monster_unittest.cc
>>  A + net/base/cookies/cookie_**options.h
>>  A + net/base/cookies/cookie_store.**h
>>  A + net/base/cookies/cookie_store.**cc
>>  A + net/base/cookies/cookie_store_**test_callbacks.h
>>  A + net/base/cookies/cookie_store_**test_callbacks.cc
>>  A + net/base/cookies/cookie_store_**test_helpers.h
>>  A + net/base/cookies/cookie_store_**test_helpers.cc
>>  A + net/base/cookies/cookie_store_**unittest.h
>>  A + net/base/cookies/cookie_util.h
>>  A + net/base/cookies/cookie_util.**cc
>>  A + net/base/cookies/cookie_util_**unittest.cc
>>  M net/net.gyp
>>
>>
>>
>

[erikwright (departed), 2012-03-15 01:07:21]

PTAL!

[willchan no longer on Chromium, 2012-03-15 03:26:54]

lgtm

[commit-bot: I haz the power, 2012-03-15 03:30:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/9703011/5003

[commit-bot: I haz the power, 2012-03-15 05:04:51]

Try job failure for 9703011-5003 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[Ryan Sleevi, 2012-03-15 06:46:07]

Drive by - tagged this as http://crbug.com/70818 - congrats! ;-)

CQ failure wasn't your fault, so I rechecked the box for you.

[commit-bot: I haz the power, 2012-03-15 06:46:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/9703011/5003

[Ryan Sleevi, 2012-03-15 06:47:27]

On 2012/03/15 06:46:07, Ryan Sleevi wrote:
> Drive by - tagged this as http://crbug.com/70818 - congrats! ;-)
> 
> CQ failure wasn't your fault, so I rechecked the box for you.

Also, if you're using git, see tools/git/mass-rename.sh

Allows you to move these files while also updating every target that depends on
them. For future use :)

[commit-bot: I haz the power, 2012-03-15 09:30:02]

Change committed as 126871