[Chromoting] Let the webapp detect new clipboard text items when it gets focus.

[Chromoting] Let the webapp detect new clipboard text items when it gets focus.

BUG=117473
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126974

[simonmorris, 2012-03-13 23:57:06]

ptal

[Jamie, 2012-03-14 00:43:47]

lgtm, with some small clean-ups.

http://codereview.chromium.org/9703003/diff/1/remoting/webapp/clipboard.js
File remoting/webapp/clipboard.js (right):

http://codereview.chromium.org/9703003/diff/1/remoting/webapp/clipboard.js#ne...
remoting/webapp/clipboard.js:37: var textType = 'text/plain';
Since this is a constant, I'd be inclined to move it out of the function and
call it TEXT_TYPE. You could even make it a single-element enum to make it clear
how it would be extended.

http://codereview.chromium.org/9703003/diff/1/remoting/webapp/document_proto.js
File remoting/webapp/document_proto.js (right):

http://codereview.chromium.org/9703003/diff/1/remoting/webapp/document_proto....
remoting/webapp/document_proto.js:12: /** @constructor
You can annotate sub-classes via @extends. However, I think it might be better
just to add execCommand directly to the prototype of document, since that's
where it actually is. You can do away with the casts if you do that.

http://codereview.chromium.org/9703003/diff/1/remoting/webapp/event_proto.js
File remoting/webapp/event_proto.js (right):

http://codereview.chromium.org/9703003/diff/1/remoting/webapp/event_proto.js#...
remoting/webapp/event_proto.js:24: remoting.Event = function() {};
Maybe ClipboardEvent would be a better name. Also, as with Document, use
@extends (I think that makes more sense than adding the fields directly to
Event, since not all events have these fields). It's a shame there's no
ClipboardEvent analogous to TextEvent and MouseEvent, but there doesn't appear
to be.

http://codereview.chromium.org/9703003/diff/1/remoting/webapp/remoting.js
File remoting/webapp/remoting.js (right):

http://codereview.chromium.org/9703003/diff/1/remoting/webapp/remoting.js#new...
remoting/webapp/remoting.js:133: var documentCast = /** @type
{remoting.Document} */ document;
This can be simpler if you just annotate execCommand as existing in
document.prototype (or just document, for that matter).

[commit-bot: I haz the power, 2012-03-15 15:49:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonmorris@chromium.org/9703003/4001

[commit-bot: I haz the power, 2012-03-15 19:58:35]

Change committed as 126974