sync: Count and report reflected updates

chrome/browser/sync/internal_api/all_status.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/internal_api/all_status.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/port.h"
@@ skipping 54 matching lines @@
   status.sync_protocol_error = snapshot->errors.sync_protocol_error;
 
   // Accumulate update count only once per session to avoid double-counting.
   // TODO(ncarter): Make this realtime by having the syncer_status
   // counter preserve its value across sessions.  http://crbug.com/26339
   if (event.what_happened == SyncEngineEvent::SYNC_CYCLE_ENDED) {
     status.updates_received +=
         snapshot->syncer_status.num_updates_downloaded_total;
     status.tombstone_updates_received +=
         snapshot->syncer_status.num_tombstone_updates_downloaded_total;
+    status.echo_updates_received +=
+        snapshot->syncer_status.num_echo_updates_downloaded_total;

[tim (not reviewing), 2012/03/20 20:43:53]

nit - Even though I like 'echo', we've historically (and currently, server side)
referred to these as reflected updates (e.g. reflection-blocking for
notifications), so it'd be nice to follow suit.

[rlarocque, 2012/03/21 17:42:34]

Done.

     status.num_local_overwrites_total +=
         snapshot->syncer_status.num_local_overwrites;
     status.num_server_overwrites_total +=
         snapshot->syncer_status.num_server_overwrites;
     if (snapshot->syncer_status.num_updates_downloaded_total == 0) {
       ++status.empty_get_updates;
     } else {
       ++status.nonempty_get_updates;
     }
     if (snapshot->syncer_status.num_successful_commits == 0) {
@@ skipping 104 matching lines @@
     : allstatus_(allstatus) {
   allstatus->mutex_.Acquire();
 }
 
 ScopedStatusLock::~ScopedStatusLock() {
   allstatus_->CalcStatusChanges();
   allstatus_->mutex_.Release();
 }
 
 }  // namespace browser_sync