Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 9702011: Migrate proxy-settings.html to options2. (Closed)

Created:
8 years, 9 months ago by kevers
Modified:
8 years, 9 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org
Visibility:
Public.

Description

Migrate proxy-settings.html to options2. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127441

Patch Set 1 #

Patch Set 2 : Update proxy settings dialog on login to use options2 resources. #

Patch Set 3 : Fix initialization of the proxy-settings dialog. #

Patch Set 4 : Style cleanup. #

Patch Set 5 : Fix copyright notices. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -17 lines) Patch
M chrome/browser/resources/chromeos/proxy_settings.css View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/proxy_settings.html View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/proxy_settings.js View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/internet_detail.js View 1 2 3 3 chunks +36 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/proxy_handler2.cc View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kevers
Hi Chris, Can you please have a look at this CL. The proxy settings dialog ...
8 years, 9 months ago (2012-03-18 16:37:49 UTC) #1
csilv
lgtm
8 years, 9 months ago (2012-03-18 18:51:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/9702011/5001
8 years, 9 months ago (2012-03-18 18:59:56 UTC) #3
commit-bot: I haz the power
Presubmit check for 9702011-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-18 18:59:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/9702011/3007
8 years, 9 months ago (2012-03-19 07:09:09 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-19 09:22:48 UTC) #6
Change committed as 127441

Powered by Google App Engine
This is Rietveld 408576698