Call libcros functions through proxy functions

Call libcros functions through proxy functions

BUG=chromium-os:16557
TEST=build success


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126859

[hashimoto, 2012-03-14 00:18:42]

Patch Set 1 is simply copying chromeos_netowrk.h.
See diff against Patch Set 1 may make review easy.

[stevenjb, 2012-03-14 21:42:45]

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/cros_network_functions.cc (right):

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cros_network_functions.cc:10: return
ActivateCellularModem(service_path, carrier);
I know that it's implicit, but I've been specifying chromeos:: for libcros
functions as an extra indicator that they are not defined locally. I think we
should do there here also.

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/cros_network_functions.h (right):

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cros_network_functions.h:21: //
nit: no blank lines in function comments here and throughout. Should be a single
paragraph (i.e. combine lines also).

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cros_network_functions.h:94: void
CrosDisconnectSMSMonitor(SMSMonitor monitor);
These functions should have comments.

[hashimoto, 2012-03-14 22:48:19]

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/cros_network_functions.cc (right):

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cros_network_functions.cc:10: return
ActivateCellularModem(service_path, carrier);
On 2012/03/14 21:42:45, stevenjb (chromium) wrote:
> I know that it's implicit, but I've been specifying chromeos:: for libcros
> functions as an extra indicator that they are not defined locally. I think we
> should do there here also.

Done.

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/cros_network_functions.h (right):

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cros_network_functions.h:21: //
On 2012/03/14 21:42:45, stevenjb (chromium) wrote:
> nit: no blank lines in function comments here and throughout. Should be a
single
> paragraph (i.e. combine lines also).

Done.

http://codereview.chromium.org/9702005/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cros_network_functions.h:94: void
CrosDisconnectSMSMonitor(SMSMonitor monitor);
On 2012/03/14 21:42:45, stevenjb (chromium) wrote:
> These functions should have comments.

Done.

[stevenjb, 2012-03-14 22:55:30]

lgtm

[commit-bot: I haz the power, 2012-03-15 01:21:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9702005/6011

[commit-bot: I haz the power, 2012-03-15 04:24:33]

Try job failure for 9702005-6011 (previous was lost) (previous was lost) (retry)
on win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-03-15 05:55:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9702005/6011

[commit-bot: I haz the power, 2012-03-15 07:16:42]

Change committed as 126859