MultiMonitor support

ui/aura/env.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/env.h"
 #include "ui/aura/env_observer.h"
 #include "ui/aura/single_monitor_manager.h"
 #include "ui/aura/root_window_host.h"
 #include "ui/aura/window.h"
+#include "ui/gfx/compositor/compositor.h"
 
 namespace aura {
 
 // static
 Env* Env::instance_ = NULL;
 
 ////////////////////////////////////////////////////////////////////////////////
 // Env, public:
 
 Env::Env()
     : mouse_button_flags_(0),
       stacking_client_(NULL),
       monitor_manager_(NULL)
 {
   SetMonitorManager(new internal::SingleMonitorManager());
 #if !defined(OS_MACOSX)
   dispatcher_.reset(CreateDispatcher());
 #endif
+  ui::Compositor::Initialize(false);
 }
 
-Env::~Env() {}
+Env::~Env() {
+  ui::Compositor::Terminate();
+}
 
 // static
 Env* Env::GetInstance() {
   if (!instance_)
     instance_ = new Env;
   return instance_;
 }
 
 // static
 void Env::DeleteInstance() {

[piman, 2012/03/20 00:31:37]

Just to confirm, where is this called from? It needs to happen after all the
root windows have been destroyed, but before we destroy the webkit thread.
I didn't see it called in ~Shell, but maybe that's done implicitly.

[oshima, 2012/03/20 02:29:58]

This is called in PostMessageLoopRun, which may be too late and 
after webkit thread was destroyed (I'm not certain). When does webkit thread get
destroyed?

 Alternatively, I can count the creation/deletion of RootWindow and Terminate
when root window count becomes 0. Let me know what you think.

[piman, 2012/03/20 04:45:46]

Ok, this is fine then, according to
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_...
I'm thinking, it would be useful to have a DCHECK just in case.

[oshima, 2012/03/20 16:31:13]

Let me clarify. Do you want to count # of current root windows and check in
~Env?

   delete instance_;
   instance_ = NULL;
 }
 
 void Env::AddObserver(EnvObserver* observer) {
   observers_.AddObserver(observer);
 }
 
 void Env::RemoveObserver(EnvObserver* observer) {
   observers_.RemoveObserver(observer);
@@ skipping 10 matching lines @@
 #endif
 
 ////////////////////////////////////////////////////////////////////////////////
 // Env, private:
 
 void Env::NotifyWindowInitialized(Window* window) {
   FOR_EACH_OBSERVER(EnvObserver, observers_, OnWindowInitialized(window));
 }
 
 }  // namespace aura