Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 9701095: cleanup: Split ibus_controller.h into 5 headers (Closed)

Created:
8 years, 9 months ago by Yusuke Sato
Modified:
8 years, 9 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

cleanup: Split ibus_controller.h into 5 headers. - Remove small classes and structures from ibus_controller.cc and .h. - Add input_method_{descriptor,property,whitelist,config}.cc and .h instead. - Do the same for ibus_controller_unittest.cc. - Move IBusController::GetSupportedInputMethods() to input_method_whitelist.h. This CL is in preparation for removing IBus dependencies from all classes except InputMethodManagerImpl. BUG=chromium-os:19655 TEST=try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127435

Patch Set 1 : review #

Patch Set 2 : clang fix #

Patch Set 3 : another clang fix #

Patch Set 4 : rebase #

Patch Set 5 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+593 lines, -418 lines) Patch
M chrome/browser/chromeos/input_method/ibus_controller.h View 1 2 3 4 3 chunks +4 lines, -126 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller.cc View 3 chunks +1 line, -187 lines 0 comments Download
D chrome/browser/chromeos/input_method/ibus_controller_unittest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_config.h View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_config.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_descriptor.h View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_descriptor.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_descriptor_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 4 chunks +5 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_property.h View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_property.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 3 chunks +3 lines, -15 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_whitelist.h View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_whitelist.cc View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_whitelist_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
8 years, 9 months ago (2012-03-16 15:39:25 UTC) #1
Zachary Kuznia
LGTM with one nit: Add "#pragma once" to the header files.
8 years, 9 months ago (2012-03-16 16:10:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9701095/10001
8 years, 9 months ago (2012-03-18 23:51:57 UTC) #3
commit-bot: I haz the power
Try job failure for 9701095-10001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-19 02:19:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9701095/10001
8 years, 9 months ago (2012-03-19 03:09:37 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-19 05:59:24 UTC) #6
Change committed as 127435

Powered by Google App Engine
This is Rietveld 408576698