Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 9701070: Include the WebKit targets on all Android builds (Closed)

Created:
8 years, 9 months ago by Peter Beverloo
Modified:
8 years, 9 months ago
CC:
chromium-reviews, bulach, Satish
Visibility:
Public.

Description

Include the WebKit targets on all Android builds Promote DumpRenderTree and webkit_unit_tests to targets being part of All (thus out of experimental), while also adding TestWebKitAPI by correctly referring to WebKit's All.gyp instead of (the seemingly Windows-oriented) webkit/webkit.gyp. After this change, three new targets will be build for Android on the main waterfall. The compile time for new required files (they all rely heavily on webkit.a) is negligible, link time is more significant, namely ~40 seconds per target, but this will be parallelized on the bot with other targets. Increase in build time is ~50 seconds on my T3500. BUG= TEST=DumpRenderTree, webkit_unit_tests and TestWebKitAPI should be build on the Android buildbots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127459

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/all_android.gyp View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yaron
lgtm but up to jrg
8 years, 9 months ago (2012-03-15 17:33:32 UTC) #1
John Grabowski
LGTM!
8 years, 9 months ago (2012-03-15 17:35:08 UTC) #2
Peter Beverloo
+ some more people
8 years, 9 months ago (2012-03-15 17:35:17 UTC) #3
bulach
lgtm http://codereview.chromium.org/9701070/diff/1/build/all_android.gyp File build/all_android.gyp (right): http://codereview.chromium.org/9701070/diff/1/build/all_android.gyp#newcode36 build/all_android.gyp:36: # From here down: not added to run_tests.py ...
8 years, 9 months ago (2012-03-15 17:44:23 UTC) #4
Peter Beverloo
On 2012/03/15 17:44:23, bulach wrote: > lgtm > > http://codereview.chromium.org/9701070/diff/1/build/all_android.gyp > File build/all_android.gyp (right): > ...
8 years, 9 months ago (2012-03-15 17:54:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/9701070/4001
8 years, 9 months ago (2012-03-19 10:42:32 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-19 13:53:30 UTC) #7
Change committed as 127459

Powered by Google App Engine
This is Rietveld 408576698