Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 9701065: mac: Add MEDIA_EXPORT macros needed to link tests in the shared build (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

mac: Add MEDIA_EXPORT macros needed to link tests in the shared build BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126961

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.h View 1 chunk +1 line, -1 line 2 comments Download
M media/audio/mac/audio_manager_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
8 years, 9 months ago (2012-03-15 16:29:25 UTC) #1
Ami GONE FROM CHROMIUM
lgtm https://chromiumcodereview.appspot.com/9701065/diff/1/media/audio/mac/audio_low_latency_input_mac.h File media/audio/mac/audio_low_latency_input_mac.h (right): https://chromiumcodereview.appspot.com/9701065/diff/1/media/audio/mac/audio_low_latency_input_mac.h#newcode69 media/audio/mac/audio_low_latency_input_mac.h:69: MEDIA_EXPORT static double HardwareSampleRate(); Is there a reason ...
8 years, 9 months ago (2012-03-15 16:35:55 UTC) #2
Nico
Thanks! https://chromiumcodereview.appspot.com/9701065/diff/1/media/audio/mac/audio_low_latency_input_mac.h File media/audio/mac/audio_low_latency_input_mac.h (right): https://chromiumcodereview.appspot.com/9701065/diff/1/media/audio/mac/audio_low_latency_input_mac.h#newcode69 media/audio/mac/audio_low_latency_input_mac.h:69: MEDIA_EXPORT static double HardwareSampleRate(); On 2012/03/15 16:35:55, Ami ...
8 years, 9 months ago (2012-03-15 16:41:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9701065/1
8 years, 9 months ago (2012-03-15 16:47:25 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 19:08:41 UTC) #5
Change committed as 126961

Powered by Google App Engine
This is Rietveld 408576698