Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 9701059: mac: Make crypto_unittests depend on nspr (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Make crypto_unittests depend on nspr nss_util_unittest.cc calls PR_ImplodeTime, so this dependency is needed in the components build. BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M crypto/crypto.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
(please check cq if you get to this in the next hour)
8 years, 9 months ago (2012-03-15 05:08:44 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-15 05:43:32 UTC) #2
Ryan Sleevi
lgtm
8 years, 9 months ago (2012-03-15 05:43:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9701059/1
8 years, 9 months ago (2012-03-15 05:43:44 UTC) #4
commit-bot: I haz the power
Try job failure for 9701059-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-15 07:56:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9701059/1
8 years, 9 months ago (2012-03-15 13:39:57 UTC) #6
commit-bot: I haz the power
Try job failure for 9701059-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-15 16:27:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9701059/1
8 years, 9 months ago (2012-03-15 16:38:37 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 19:07:42 UTC) #9
Change committed as 126958

Powered by Google App Engine
This is Rietveld 408576698