Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 9701039: Refactor folders in chrome/browser/extensions/api (Closed)

Created:
8 years, 9 months ago by cduvall
Modified:
8 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refactor folders in chrome/browser/extensions/api Renamed folders to the form the_folder instead of thefolder BUG=118230 TEST=*BrowsingData*, *WebRequest* TBR=mattm@chromium.org, miranda@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127388

Patch Set 1 #

Patch Set 2 : Minor changes #

Patch Set 3 : Merged to resolve commit issue #

Patch Set 4 : Small change to includes in extension_event_router.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -5762 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/extensions/api/browsing_data/browsing_data_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/browsingdata/browsing_data_api.h View 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/extensions/api/browsingdata/browsing_data_api.cc View 1 1 chunk +0 lines, -241 lines 0 comments Download
D chrome/browser/extensions/api/browsingdata/browsing_data_test.cc View 1 chunk +0 lines, -140 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_api.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_api.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_api_constants.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_api_constants.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_api_helpers.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_time_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_time_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/extensions/api/web_request/web_request_time_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_api.h View 1 chunk +0 lines, -383 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_api.cc View 1 1 chunk +0 lines, -1746 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_api_constants.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_api_constants.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_api_helpers.h View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_api_helpers.cc View 1 chunk +0 lines, -547 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_api_unittest.cc View 1 chunk +0 lines, -1444 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_apitest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_time_tracker.h View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_time_tracker.cc View 1 chunk +0 lines, -253 lines 0 comments Download
D chrome/browser/extensions/api/webrequest/webrequest_time_tracker_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
cduvall
Folders are now named consistently as requested. :)
8 years, 9 months ago (2012-03-17 18:13:12 UTC) #1
Aaron Boodman
lgtm, thanks!
8 years, 9 months ago (2012-03-17 19:49:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/9701039/4001
8 years, 9 months ago (2012-03-17 19:54:32 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/extensions/extension_function_dispatcher.cc. While running patch -p1 --forward --force; patching file chrome/browser/extensions/extension_function_dispatcher.cc ...
8 years, 9 months ago (2012-03-17 19:54:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/9701039/7001
8 years, 9 months ago (2012-03-17 20:01:25 UTC) #5
commit-bot: I haz the power
Presubmit check for 9701039-7001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-17 20:01:36 UTC) #6
cduvall
On 2012/03/17 20:01:36, I haz the power (commit-bot) wrote: > Presubmit check for 9701039-7001 failed ...
8 years, 9 months ago (2012-03-17 20:08:46 UTC) #7
Aaron Boodman
On 2012/03/17 20:08:46, cduvall wrote: > On 2012/03/17 20:01:36, I haz the power (commit-bot) wrote: ...
8 years, 9 months ago (2012-03-17 21:55:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/9701039/7001
8 years, 9 months ago (2012-03-17 21:56:34 UTC) #9
commit-bot: I haz the power
Try job failure for 9701039-7001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-17 22:18:10 UTC) #10
cduvall
On 2012/03/17 22:18:10, I haz the power (commit-bot) wrote: > Try job failure for 9701039-7001 ...
8 years, 9 months ago (2012-03-17 22:19:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/9701039/2020
8 years, 9 months ago (2012-03-17 22:21:22 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-03-18 01:34:20 UTC) #13
Change committed as 127388

Powered by Google App Engine
This is Rietveld 408576698