Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9701006: Don't build the task manager into Android builds. (Closed)

Created:
8 years, 9 months ago by Jesse Greenwald
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Don't build the task manager into Android builds. BUG=117407 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131055

Patch Set 1 #

Total comments: 4

Patch Set 2 : Resolve yfriedman's comments #

Total comments: 4

Patch Set 3 : Resolve jam's commnents about not ifdef'ing includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -4 lines) Patch
M build/common.gypi View 1 2 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Yaron
I'm not sure it's worth changing extensions to be able to work without task manager ...
8 years, 9 months ago (2012-03-14 13:36:38 UTC) #1
Jesse Greenwald
https://chromiumcodereview.appspot.com/9701006/diff/1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): https://chromiumcodereview.appspot.com/9701006/diff/1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc#newcode161 chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:161: * Please keep this in alphabetical order. If #ifs ...
8 years, 8 months ago (2012-03-30 21:54:47 UTC) #2
Jesse Greenwald
willchan: - chrome/browser/net/chrome_network_delegate.cc estade: - chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc battre: - chrome/browser/prefs/browser_prefs.cc jam: - build/common.gypi - chrome/browser/renderer_host/chrome_render_message_filter.cc - ...
8 years, 8 months ago (2012-03-30 21:55:46 UTC) #3
Jesse Greenwald
willchan: - chrome/browser/net/chrome_network_delegate.cc estade: - chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc battre: - chrome/browser/prefs/browser_prefs.cc jam: - build/common.gypi - chrome/browser/renderer_host/chrome_render_message_filter.cc - ...
8 years, 8 months ago (2012-03-30 21:55:46 UTC) #4
battre
LGTM @chrome/browser/prefs/browser_prefs.cc Please remember to fill the BUG= field.
8 years, 8 months ago (2012-03-30 23:11:09 UTC) #5
jam
http://codereview.chromium.org/9701006/diff/4001/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): http://codereview.chromium.org/9701006/diff/4001/chrome/browser/net/chrome_network_delegate.cc#newcode40 chrome/browser/net/chrome_network_delegate.cc:40: #if defined(ENABLE_TASK_MANAGER) nit: you don't need this ifdef, so ...
8 years, 8 months ago (2012-04-02 15:49:28 UTC) #6
willchan no longer on Chromium
chrome/browser/net/ LGTM On 2012/04/02 15:49:28, John Abd-El-Malek wrote: > http://codereview.chromium.org/9701006/diff/4001/chrome/browser/net/chrome_network_delegate.cc > File chrome/browser/net/chrome_network_delegate.cc (right): > ...
8 years, 8 months ago (2012-04-02 17:10:31 UTC) #7
Jesse Greenwald
jam - resolved your comments, PTAL
8 years, 8 months ago (2012-04-02 18:05:38 UTC) #8
jam
lgtm
8 years, 8 months ago (2012-04-02 20:20:43 UTC) #9
Evan Stade
lgtm
8 years, 8 months ago (2012-04-03 03:40:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/9701006/4003
8 years, 8 months ago (2012-04-03 15:52:52 UTC) #11
commit-bot: I haz the power
Try job failure for 9701006-4003 (retry) (retry) on mac_rel for step "compile" (clobber build). It's ...
8 years, 8 months ago (2012-04-03 18:18:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/9701006/4003
8 years, 8 months ago (2012-04-03 23:46:46 UTC) #13
commit-bot: I haz the power
Try job failure for 9701006-4003 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=5980 Step "update" is always ...
8 years, 8 months ago (2012-04-04 00:43:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/9701006/4003
8 years, 8 months ago (2012-04-05 22:59:03 UTC) #15
commit-bot: I haz the power
8 years, 8 months ago (2012-04-06 01:11:05 UTC) #16 
Change committed as 131055

Powered by Google App Engine
This is Rietveld 408576698