Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9701002: Aura/ash split: Split the extra parts into ash and aura parts. (Closed)

Created:
8 years, 9 months ago by Elliot Glaysher
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, dcheng
Visibility:
Public.

Description

Aura/ash split: Split the extra parts into ash and aura parts. Also cleans up USE_AURA->USE_ASH in several files where appropriate. BUG=116458 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127034

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase to trunk to try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -107 lines) Patch
M build/all.gyp View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 4 chunks +8 lines, -3 lines 0 comments Download
A + chrome/browser/chrome_browser_main_extra_parts_ash.h View 1 chunk +6 lines, -6 lines 0 comments Download
A + chrome/browser/chrome_browser_main_extra_parts_ash.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 3 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Elliot Glaysher
8 years, 9 months ago (2012-03-13 23:17:39 UTC) #1
sky
https://chromiumcodereview.appspot.com/9701002/diff/1/chrome/browser/chrome_browser_main_extra_parts_aura.cc File chrome/browser/chrome_browser_main_extra_parts_aura.cc (left): https://chromiumcodereview.appspot.com/9701002/diff/1/chrome/browser/chrome_browser_main_extra_parts_aura.cc#oldcode36 chrome/browser/chrome_browser_main_extra_parts_aura.cc:36: #if defined(OS_CHROMEOS) Where did all of this code end ...
8 years, 9 months ago (2012-03-13 23:49:11 UTC) #2
Elliot Glaysher
https://chromiumcodereview.appspot.com/9701002/diff/1/chrome/browser/chrome_browser_main_extra_parts_aura.cc File chrome/browser/chrome_browser_main_extra_parts_aura.cc (left): https://chromiumcodereview.appspot.com/9701002/diff/1/chrome/browser/chrome_browser_main_extra_parts_aura.cc#oldcode36 chrome/browser/chrome_browser_main_extra_parts_aura.cc:36: #if defined(OS_CHROMEOS) On 2012/03/13 23:49:11, sky wrote: > Where ...
8 years, 9 months ago (2012-03-13 23:51:25 UTC) #3
sky
My mistake, LGTM
8 years, 9 months ago (2012-03-13 23:53:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9701002/1
8 years, 9 months ago (2012-03-13 23:58:01 UTC) #5
commit-bot: I haz the power
Try job failure for 9701002-1 (retry) on win_rel for steps "browser_tests, installer_util_unittests". It's a second ...
8 years, 9 months ago (2012-03-14 03:01:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9701002/4003
8 years, 9 months ago (2012-03-14 23:08:19 UTC) #7
commit-bot: I haz the power
Try job failure for 9701002-4003 (retry) (retry) on win_rel for step "browser_tests" (clobber build). It's ...
8 years, 9 months ago (2012-03-15 03:02:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9701002/4003
8 years, 9 months ago (2012-03-15 19:26:07 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 23:57:51 UTC) #10 
Change committed as 127034

Powered by Google App Engine
This is Rietveld 408576698