Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Issue 9700075: Add .ocx to the list of dangerous extensions (Closed)

Created:
8 years, 9 months ago by asanka
Modified:
8 years, 9 months ago
Reviewers:
Cris Neckar
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Add .ocx to the list of dangerous extensions BUG=118256 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128181

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/download/download_extensions.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
asanka
8 years, 9 months ago (2012-03-15 21:54:55 UTC) #1
Randy Smith (Not in Mondays)
I have no opinion on this; I don't even know what .ocx *is*.
8 years, 9 months ago (2012-03-15 22:07:40 UTC) #2
Cris Neckar
lgtm OCXs have similar issues to DLLs so if we are concerned about .manifest and ...
8 years, 9 months ago (2012-03-15 22:12:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9700075/3002
8 years, 9 months ago (2012-03-16 06:03:54 UTC) #4
commit-bot: I haz the power
Try job failure for 9700075-3002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-16 06:48:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9700075/3002
8 years, 9 months ago (2012-03-16 17:47:40 UTC) #6
commit-bot: I haz the power
Try job failure for 9700075-3002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-16 18:26:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9700075/3002
8 years, 9 months ago (2012-03-22 05:52:56 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 06:56:13 UTC) #9
Change committed as 128181

Powered by Google App Engine
This is Rietveld 408576698