dbus/file_descriptor.cc - Issue 9700072: dbus: add support for passing file descriptors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: dbus/file_descriptor.cc

Issue 9700072: dbus: add support for passing file descriptors (Closed) Base URL: http://git.chromium.org/git/chromium/src@master

Patch Set: add dbus::FileDescriptor per keybuk's request Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/platform_file.h"

	6 #include "dbus/file_descriptor.h"

	7

	8 namespace dbus {

	9

	10 FileDescriptor::~FileDescriptor() {

	11 if (owner_)
	satorux1 2012/03/28 00:32:43 If we get rid of owner_, this becomes if (value If we get rid of owner_, this becomes if (value_ == -1) Sam Leffler 2012/03/28 17:28:09 Please explain how to get rid of owner_. instance Please explain how to get rid of owner_. instances may have a valid value_ and have owner_ true or false.
	12 base::ClosePlatformFile(value_);

	13 }

	14

	15 } // namespace dbus
	keybuk 2012/03/27 22:36:35 nit: two spaces before // nit: two spaces before // Sam Leffler 2012/03/27 23:20:40 copied from object_path; fixed copied from object_path; fixed
OLD	NEW