Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 9700055: mac: Remove explicit dependency from many test targets on webcore (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Remove explicit dependency from many test targets on webcore This was added back when we were using a 32bit linker, as a manual hint to ld. Now that webcore is split up and we use a 64bit linker, it's no longer necessary. It also breaks the component build, which relies on everything just depending on libwebkit.dylib. BUG=43791, 90078 TEST=things still build TBR=mark Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126913

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -67 lines) Patch
M chrome/chrome_tests.gypi View 1 10 chunks +0 lines, -67 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
8 years, 9 months ago (2012-03-15 04:35:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9700055/1
8 years, 9 months ago (2012-03-15 04:35:41 UTC) #2
commit-bot: I haz the power
Try job failure for 9700055-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-15 05:51:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9700055/1
8 years, 9 months ago (2012-03-15 13:40:30 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/chrome_tests.gypi. While running patch -p1 --forward --force; patching file chrome/chrome_tests.gypi ...
8 years, 9 months ago (2012-03-15 13:40:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9700055/6003
8 years, 9 months ago (2012-03-15 13:47:00 UTC) #6
commit-bot: I haz the power
Change committed as 126913
8 years, 9 months ago (2012-03-15 15:22:56 UTC) #7
Robert Sesek
Why was this TBRed?
8 years, 9 months ago (2012-03-15 15:32:24 UTC) #8
Nico
On 2012/03/15 15:32:24, rsesek wrote: > Why was this TBRed? Is there a problem with ...
8 years, 9 months ago (2012-03-15 15:41:36 UTC) #9
Mark Mentovai
8 years, 9 months ago (2012-03-15 16:46:52 UTC) #10
LGTM, but this wasn’t so crucial that it needed to be committed as TBR. Lay off
the TBR switch a little bit.

Powered by Google App Engine
This is Rietveld 408576698