Correctly handle FindNext from the Find dialog.

Correctly handle FindNext from the Find dialog.
Also handle unselecting the current selection when the Find dialog is dismissed.

BUG=112193
TEST=Open the find dialog in CF, search for the same string twice.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126904

[grt (UTC plus 2), 2012-03-15 02:29:51]

LGTM with two nits and one minor efficiency suggestion, which you're welcome to
ignore.

https://chromiumcodereview.appspot.com/9700053/diff/1/chrome_frame/find_dialo...
File chrome_frame/find_dialog.cc (right):

https://chromiumcodereview.appspot.com/9700053/diff/1/chrome_frame/find_dialo...
chrome_frame/find_dialog.cc:29: std::string guid = guid::GenerateGUID();
nit: std::string guid(guid::GenerateGUID());

https://chromiumcodereview.appspot.com/9700053/diff/1/chrome_frame/find_dialo...
chrome_frame/find_dialog.cc:39: GetDlgItemText(IDC_FIND_TEXT, buffer,
kMaxFindChars);
what do you think about doing this to avoid extra copies and strlens:
string16 find_text(kMaxFindChars, L'\0');
find_text.resize(GetDlgItemText(IDC_FIND_TEXT, &find_text[0], kMaxFindChars));

https://chromiumcodereview.appspot.com/9700053/diff/1/chrome_frame/find_dialo...
chrome_frame/find_dialog.cc:44: if (!find_next) {
remove braces (chromium hates wasted vertical space)

[robertshield, 2012-03-15 02:54:22]

Thanks!

https://chromiumcodereview.appspot.com/9700053/diff/1/chrome_frame/find_dialo...
File chrome_frame/find_dialog.cc (right):

https://chromiumcodereview.appspot.com/9700053/diff/1/chrome_frame/find_dialo...
chrome_frame/find_dialog.cc:29: std::string guid = guid::GenerateGUID();
On 2012/03/15 02:29:52, grt wrote:
> nit: std::string guid(guid::GenerateGUID());

Done.

https://chromiumcodereview.appspot.com/9700053/diff/1/chrome_frame/find_dialo...
chrome_frame/find_dialog.cc:39: GetDlgItemText(IDC_FIND_TEXT, buffer,
kMaxFindChars);
On 2012/03/15 02:29:52, grt wrote:
> what do you think about doing this to avoid extra copies and strlens:
> string16 find_text(kMaxFindChars, L'\0');
> find_text.resize(GetDlgItemText(IDC_FIND_TEXT, &find_text[0], kMaxFindChars));

lgtm, done

https://chromiumcodereview.appspot.com/9700053/diff/1/chrome_frame/find_dialo...
chrome_frame/find_dialog.cc:44: if (!find_next) {
On 2012/03/15 02:29:52, grt wrote:
> remove braces (chromium hates wasted vertical space)

Done.

[commit-bot: I haz the power, 2012-03-15 02:57:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/9700053/4001

[commit-bot: I haz the power, 2012-03-15 04:39:42]

Try job failure for 9700053-4001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-03-15 11:23:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/9700053/4001

[commit-bot: I haz the power, 2012-03-15 13:50:02]

Change committed as 126904