Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 9700043: When sizing to fit the extension install dialog title, expand the height instead of the width. (Closed)

Created:
8 years, 9 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

When sizing to fit the extension install dialog title, expand the height instead of the width. This prevents the re-enable prompt (and/or long app/extension names) from making the dialog too wide. BUG=118279 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 3 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mihai Parparita -not on Chrome
This look like http://cl.ly/3s3X3z1k3C1R2U0P3y1V (see bug for the "before" picture)
8 years, 9 months ago (2012-03-14 23:24:22 UTC) #1
Nico
LGTM Might look weird if a localized string is more than 4 lines. I guess ...
8 years, 9 months ago (2012-03-14 23:33:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/9700043/1
8 years, 9 months ago (2012-03-14 23:44:19 UTC) #3
commit-bot: I haz the power
Try job failure for 9700043-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-15 02:39:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/9700043/1
8 years, 9 months ago (2012-03-15 04:31:42 UTC) #5
commit-bot: I haz the power
Try job failure for 9700043-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-15 05:55:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/9700043/1
8 years, 9 months ago (2012-03-15 13:42:32 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 16:27:00 UTC) #8
Change committed as 126924

Powered by Google App Engine
This is Rietveld 408576698