ScopedProcessInformation protects against process/thread handle leaks from CreateProcess calls.

chrome/installer/util/product.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/product.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/process_util.h"
 #include "base/win/registry.h"
+#include "base/win/scoped_process_information.h"
 #include "chrome/installer/util/chrome_browser_operations.h"
 #include "chrome/installer/util/chrome_browser_sxs_operations.h"
 #include "chrome/installer/util/chrome_frame_operations.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/helper.h"
 #include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/master_preferences.h"
 #include "chrome/installer/util/master_preferences_constants.h"
 #include "chrome/installer/util/product_operations.h"
 
@@ skipping 48 matching lines @@
                                   const CommandLine& options,
                                   int32* exit_code) const {
   if (application_path.empty())
     return false;
 
   CommandLine cmd(application_path.Append(installer::kChromeExe));
   cmd.AppendArguments(options, false);
 
   bool success = false;
   STARTUPINFOW si = { sizeof(si) };
-  PROCESS_INFORMATION pi = {0};
+  base::win::ScopedProcessInformation pi;
   // Create a writable copy of the command line string, since CreateProcess may
   // modify the string (insert \0 to separate the program from the arguments).
   std::wstring writable_command_line_string(cmd.GetCommandLineString());
   if (!::CreateProcess(cmd.GetProgram().value().c_str(),
                        &writable_command_line_string[0],
                        NULL, NULL, FALSE, CREATE_NO_WINDOW, NULL, NULL,
-                       &si, &pi)) {
+                       &si, pi.Receive())) {
     PLOG(ERROR) << "Failed to launch: " << cmd.GetCommandLineString();
   } else {
-    ::CloseHandle(pi.hThread);
-
-    DWORD ret = ::WaitForSingleObject(pi.hProcess, INFINITE);
+    DWORD ret = ::WaitForSingleObject(pi.Get().hProcess, INFINITE);
     DLOG_IF(ERROR, ret != WAIT_OBJECT_0)
         << "Unexpected return value from WaitForSingleObject: " << ret;
-    if (::GetExitCodeProcess(pi.hProcess, &ret)) {
+    if (::GetExitCodeProcess(pi.Get().hProcess, &ret)) {
       DCHECK(ret != STILL_ACTIVE);
       success = true;
       if (exit_code)
         *exit_code = ret;
     } else {
       PLOG(ERROR) << "GetExitCodeProcess failed";
     }
-
-    ::CloseHandle(pi.hProcess);
   }
 
   return success;
 }
 
 bool Product::SetMsiMarker(bool system_install, bool set) const {
   HKEY reg_root = system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   RegKey client_state_key;
   LONG result = client_state_key.Open(reg_root,
       distribution_->GetStateKey().c_str(), KEY_READ | KEY_WRITE);
@@ skipping 26 matching lines @@
 
 void Product::AppendRenameFlags(CommandLine* command_line) const {
   operations_->AppendRenameFlags(options_, command_line);
 }
 
 bool Product::SetChannelFlags(bool set, ChannelInfo* channel_info) const {
   return operations_->SetChannelFlags(options_, set, channel_info);
 }
 
 }  // namespace installer